Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-25 15:15:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(nuxt): avoid early returning renderer with empty response (#21439)

Browse Source
This commit is contained in:
pooya parsa 2023-06-07 15:11:59 +02:00 committed by GitHub
parent f5e65171a2
commit 05f3decfa9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/nuxt/src/core/runtime/nitro/renderer.ts
View File

@ -259,11 +259,6 @@ export default defineRenderHandler(async (event): Promise<Partial<RenderResponse
if (ssrContext._renderResponse) { return ssrContext._renderResponse } if (ssrContext._renderResponse) { return ssrContext._renderResponse }
if (event.node.res.headersSent || event.node.res.writableEnded) {
// @ts-expect-error TODO: handle additional cases
return
}
// Handle errors // Handle errors
if (ssrContext.payload?.error && !ssrError) { if (ssrContext.payload?.error && !ssrError) {
throw ssrContext.payload.error throw ssrContext.payload.error

2
test/bundle.test.ts
View File

@ -45,7 +45,7 @@ describe.skipIf(isWindows || process.env.TEST_BUILDER === 'webpack' || process.e
it('default server bundle size', async () => { it('default server bundle size', async () => {
stats.server = await analyzeSizes(['**/*.mjs', '!node_modules'], serverDir) stats.server = await analyzeSizes(['**/*.mjs', '!node_modules'], serverDir)
expect(roundToKilobytes(stats.server.totalBytes)).toMatchInlineSnapshot('"62.8k"') expect(roundToKilobytes(stats.server.totalBytes)).toMatchInlineSnapshot('"62.7k"')
const modules = await analyzeSizes('node_modules/**/*', serverDir) const modules = await analyzeSizes('node_modules/**/*', serverDir)
expect(roundToKilobytes(modules.totalBytes)).toMatchInlineSnapshot('"2286k"') expect(roundToKilobytes(modules.totalBytes)).toMatchInlineSnapshot('"2286k"')