chore: remove comment

This commit is contained in:
Daniel Roe 2024-12-09 12:46:26 +00:00
parent 7ac69b6103
commit 0651291f77
No known key found for this signature in database
GPG Key ID: 3714AB03996F442B

View File

@ -7,9 +7,11 @@ const isWebpack =
process.env.TEST_BUILDER === 'webpack' || process.env.TEST_BUILDER === 'webpack' ||
process.env.TEST_BUILDER === 'rspack' process.env.TEST_BUILDER === 'rspack'
const isDev = process.env.TEST_ENV === 'dev'
await setup({ await setup({
rootDir: fileURLToPath(new URL('../fixtures/spa-loader', import.meta.url)), rootDir: fileURLToPath(new URL('../fixtures/spa-loader', import.meta.url)),
dev: process.env.TEST_ENV === 'dev', dev: isDev,
server: true, server: true,
browser: true, browser: true,
setupTimeout: (isWindows ? 360 : 120) * 1000, setupTimeout: (isWindows ? 360 : 120) * 1000,
@ -30,27 +32,7 @@ describe('spaLoadingTemplateLocation flag is set to `within`', () => {
) )
}) })
/** it.skipIf(isDev)('spa-loader does not appear while the app is mounting', async () => {
* This test is skipped in dev mode because it not working
* possible fix is set timeout to 1000
* ```
* const browser = await getBrowser()
* const page = await browser.newPage({})
* await page.goto(url('/spa'), { waitUntil: 'domcontentloaded' })
*
* const loader = page.getByTestId('loader')
* if (process.env.TEST_ENV === 'dev') {
* await page.waitForTimeout(1000)
* }
* expect(await loader.isHidden()).toBeTruthy()
*
* await page.close()
*}, 60_000)
*```
*/
it.skipIf(process.env.TEST_ENV === 'dev')(
'spa-loader does not appear while the app is mounting',
async () => {
const browser = await getBrowser() const browser = await getBrowser()
const page = await browser.newPage({}) const page = await browser.newPage({})
await page.goto(url('/spa'), { waitUntil: 'domcontentloaded' }) await page.goto(url('/spa'), { waitUntil: 'domcontentloaded' })