refactor: change function calls when arity is one (#3563)

bin/nuxt

@@ -4,9 +4,7 @@ const { join } = require('path')
 const consola = require('consola')
 
 // Global error handler
-process.on('unhandledRejection', _error => {
+process.on('unhandledRejection', consola.error)
-  consola.error(_error)
-})
 
 // Exit process on fatal errors
 consola.add({
@@ -21,7 +19,7 @@ consola.add({
 const defaultCommand = 'dev'
 const commands = new Set([defaultCommand, 'init', 'build', 'start', 'generate'])
 
-var cmd = process.argv[2]
+let cmd = process.argv[2]
 
 if (commands.has(cmd)) {
   process.argv.splice(2, 1)

bin/nuxt-build

@@ -51,7 +51,7 @@ const nuxt = new Nuxt(options)
 const builder = new Builder(nuxt)
 
 // Setup hooks
-nuxt.hook('error', (_err) => consola.fatal(_err))
+nuxt.hook('error', consola.fatal)
 
 // Close function
 const close = () => {
@@ -68,12 +68,12 @@ if (options.mode !== 'spa' || argv.generate === false) {
   // Build only
   builder
     .build()
-    .then(() => close())
+    .then(close)
-    .catch(error => consola.fatal(error))
+    .catch(consola.fatal)
 } else {
   // Build + Generate for static deployment
   new Generator(nuxt, builder)
     .generate({ build: true })
-    .then(() => close())
+    .then(close)
-    .catch(error => consola.fatal(error))
+    .catch(consola.fatal)
 }

bin/nuxt-dev

@@ -115,7 +115,7 @@ function startDev(oldInstance) {
         }
       })
       // Start build
-      .then(() => builder.build())
+      .then(builder.build)
       // Close old nuxt after successful build
       .then(
         () =>

bin/nuxt-generate

@@ -53,4 +53,4 @@ generator
   .then(() => {
     process.exit(0)
   })
-  .catch(error => consola.fatal(error))
+  .catch(consola.fatal)

bin/nuxt-start

@@ -52,7 +52,7 @@ options.dev = false
 const nuxt = new Nuxt(options)
 
 // Setup hooks
-nuxt.hook('error', (_err) => consola.fatal(_err))
+nuxt.hook('error', consola.fatal)
 
 // Check if project is built for production
 const distDir = resolve(

examples/storybook/.storybook/config.js

@@ -15,7 +15,7 @@ Vue.component('my-button', MyButton)
 const req = require.context('../stories', true, /.story.js$/)
 
 function loadStories() {
-  req.keys().forEach((filename) => req(filename))
+  req.keys().forEach(req)
 }
 
 configure(loadStories, module)

examples/vue-chartjs/pages/contributors.vue

@@ -9,9 +9,9 @@ import DoughnutChart from '~/components/doughnut-chart'
 import axios from 'axios'
 
 function getRandomColor() {
-  var letters = '0123456789ABCDEF'
+  const letters = '0123456789ABCDEF'
-  var color = '#'
+  let color = '#'
-  for (var i = 0; i < 6; i++) {
+  for (let i = 0; i < 6; i++) {
     color += letters[Math.floor(Math.random() * 16)]
   }
   return color
@@ -26,8 +26,8 @@ export default {
         datasets: [
           {
             label: 'Nuxt.js Contributors',
-            backgroundColor: res.data.map(() => getRandomColor()),
+            backgroundColor: res.data.map(getRandomColor),
-            data: res.data.map((stat) => 1)
+            data: res.data.map(() => 1)
           }
         ]
       }

examples/with-feathers/test/app.test.js

@@ -5,7 +5,7 @@ import app from '../src/app'
 describe('Feathers application tests', function () {
   before(function (done) {
     this.server = app.listen(3030)
-    this.server.once('listening', () => done())
+    this.server.once('listening', done)
   })
 
   after(function (done) {

examples/with-sockets/io/index.js

@@ -8,7 +8,7 @@ export default function () {
   // overwrite nuxt.listen()
   this.nuxt.listen = (port, host) => new Promise((resolve) => server.listen(port || 3000, host || 'localhost', resolve))
   // close this server on 'close' event
-  this.nuxt.hook('close', () => new Promise((resolve) => server.close(resolve)))
+  this.nuxt.hook('close', () => new Promise(server.close))
 
   // Add socket.io events
   let messages = []

lib/app/utils.js

@@ -155,7 +155,7 @@ export async function setContext(app, context) {
         }
       }
     }
-    if (process.server) app.context.beforeNuxtRender = (fn) => context.beforeRenderFns.push(fn)
+    if (process.server) app.context.beforeNuxtRender = fn => context.beforeRenderFns.push(fn)
     if (process.client) app.context.nuxtState = window.__NUXT__
   }
   // Dynamic keys

lib/builder/builder.js

@@ -47,7 +47,7 @@ export default class Builder {
 
     // Stop watching on nuxt.close()
     if (this.options.dev) {
-      this.nuxt.hook('close', () => this.unwatch())
+      this.nuxt.hook('close', this.unwatch)
     }
 
     // Initialize shared FS and Cache
@@ -57,7 +57,7 @@ export default class Builder {
 
     // if(!this.options.dev) {
     // TODO: enable again when unsafe concern resolved.(common/options.js:42)
-    // this.nuxt.hook('build:done', () => this.generateConfig())
+    // this.nuxt.hook('build:done', this.generateConfig)
     // }
   }
 
@@ -599,7 +599,7 @@ export default class Builder {
         r(src, `${this.options.dir.pages}/**/*.{vue,js}`)
       )
     }
-    patterns = _.map(patterns, p => upath.normalizeSafe(p))
+    patterns = _.map(patterns, upath.normalizeSafe)
 
     const options = Object.assign({}, this.options.watchers.chokidar, {
       ignoreInitial: true
@@ -618,9 +618,7 @@ export default class Builder {
       this.options.build.watch,
       ..._.values(_.omit(this.options.build.styleResources, ['options']))
     )
-    customPatterns = _.map(_.uniq(customPatterns), p =>
+    customPatterns = _.map(_.uniq(customPatterns), upath.normalizeSafe)
-      upath.normalizeSafe(p)
-    )
     this.customFilesWatcher = chokidar
       .watch(customPatterns, options)
       .on('change', refreshFiles)

lib/builder/webpack/plugins/vue/util.js

@@ -31,6 +31,6 @@ export const onEmit = (compiler, name, hook) => {
   }
 }
 
-export const isJS = (file) => /\.js(\?[^.]+)?$/.test(file)
+export const isJS = file => /\.js(\?[^.]+)?$/.test(file)
 
-export const isCSS = (file) => /\.css(\?[^.]+)?$/.test(file)
+export const isCSS = file => /\.css(\?[^.]+)?$/.test(file)

lib/common/options.js

@@ -65,7 +65,7 @@ Options.from = function (_options) {
   options.modulesDir = []
     .concat(options.modulesDir)
     .concat(path.join(options.nuxtDir, 'node_modules'))
-    .filter(dir => hasValue(dir))
+    .filter(hasValue)
     .map(dir => path.resolve(options.rootDir, dir))
 
   // Sanitize extensions

lib/common/utils.js

@@ -82,7 +82,7 @@ export const sequence = function sequence(tasks, fn) {
 }
 
 export const parallel = function parallel(tasks, fn) {
-  return Promise.all(tasks.map(task => fn(task)))
+  return Promise.all(tasks.map(fn))
 }
 
 export const chainFn = function chainFn(base, fn) {