Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-27 08:02:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(webpack): loaders in extend config is broken (#5292)

Browse Source
This commit is contained in:
Xin Du (Clark) 2019-03-20 12:08:24 +00:00 committed by Pooya Parsa
parent ef41e205e6
commit 0eb5ed9763
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/webpack/src/config/base.js
View File

@ -442,7 +442,7 @@ export default class WebpackBaseConfig {
} }
// Clone deep avoid leaking config between Client and Server // Clone deep avoid leaking config between Client and Server
const extendedConfig = this.extendConfig(cloneDeep(config)) const extendedConfig = cloneDeep(this.extendConfig(config))
const { optimization } = extendedConfig const { optimization } = extendedConfig
// Todo remove in nuxt 3 in favor of devtool config property or https://webpack.js.org/plugins/source-map-dev-tool-plugin // Todo remove in nuxt 3 in favor of devtool config property or https://webpack.js.org/plugins/source-map-dev-tool-plugin
if (optimization && optimization.minimizer && extendedConfig.devtool) { if (optimization && optimization.minimizer && extendedConfig.devtool) {

2
test/unit/basic.dev.test.js
View File

@ -93,7 +93,7 @@ describe('basic dev', () => {
) )
const { cssModules, vue } = loadersOptions const { cssModules, vue } = loadersOptions
expect(cssModules.localIdentName).toBe('[hash:base64:6]') expect(cssModules.localIdentName).toBe('[hash:base64:6]')
expect(vueLoader.options).toEqual(vue) expect(vueLoader.options).toBe(vue)
}) })
test('Config: preset-env and cssnano are at then end of postcss plugins', () => { test('Config: preset-env and cssnano are at then end of postcss plugins', () => {