From 1155d1b4d4e46a8e93762349868b23374337bdb6 Mon Sep 17 00:00:00 2001
From: Anthony Fu <anthonyfu117@hotmail.com>
Date: Thu, 6 Jan 2022 02:28:04 +0800
Subject: [PATCH] fix(vite): only remove version query (#2587)

---
 packages/vite/src/dev-bundler.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/vite/src/dev-bundler.ts b/packages/vite/src/dev-bundler.ts
index 0c006b01ae..2e357c0a68 100644
--- a/packages/vite/src/dev-bundler.ts
+++ b/packages/vite/src/dev-bundler.ts
@@ -3,7 +3,6 @@ import { existsSync } from 'fs'
 import { resolve } from 'pathe'
 import * as vite from 'vite'
 import { ExternalsOptions, isExternal as _isExternal, ExternalsDefaults } from 'externality'
-import { parseURL } from 'ufo'
 import { hashId, uniq } from './utils'
 
 export interface TransformChunk {
@@ -70,11 +69,12 @@ async function transformRequest (opts: TransformOptions, id: string) {
     }
   }
 
-  const { pathname } = parseURL(id)
-
-  if (await isExternal(opts, pathname)) {
+  // Vite will add ?v=123 to bypass browser cache
+  // Remove for externals
+  const withoutVersionQuery = id.replace(/\?v=\w+$/, '')
+  if (await isExternal(opts, withoutVersionQuery)) {
     return {
-      code: `(global, exports, importMeta, ssrImport, ssrDynamicImport, ssrExportAll) => import('${(pathToFileURL(pathname))}').then(r => { exports.default = r.default; ssrExportAll(r) }).catch(e => { console.error(e); throw new Error('[vite dev] Error loading external "${id}".') })`,
+      code: `(global, exports, importMeta, ssrImport, ssrDynamicImport, ssrExportAll) => import('${(pathToFileURL(withoutVersionQuery))}').then(r => { exports.default = r.default; ssrExportAll(r) }).catch(e => { console.error(e); throw new Error('[vite dev] Error loading external "${id}".') })`,
       deps: [],
       dynamicDeps: []
     }