Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2025-02-18 22:51:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): remove duplicate error message in start and build (#4258)

Browse Source
This commit is contained in:
Clark Du 2018-11-02 13:54:58 +00:00 committed by Pooya Parsa
parent 12151d81d6
commit 17e0890c90
4 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/cli/src/commands/build.js
View File

@ -56,9 +56,6 @@ export default {
await cmd.getNuxtConfig(argv, { dev: false }) await cmd.getNuxtConfig(argv, { dev: false })
) )
// Setup hooks
nuxt.hook('error', err => consola.fatal(err))
let builderOrGenerator let builderOrGenerator
if (nuxt.options.mode !== 'spa' || argv.generate === false) { if (nuxt.options.mode !== 'spa' || argv.generate === false) {
// Build only // Build only

3
packages/cli/src/commands/start.js
View File

@ -30,9 +30,6 @@ export default {
await cmd.getNuxtConfig(argv, { dev: false }) await cmd.getNuxtConfig(argv, { dev: false })
) )
// Setup hooks
nuxt.hook('error', err => consola.fatal(err))
// Check if project is built for production // Check if project is built for production
const distDir = path.resolve( const distDir = path.resolve(
nuxt.options.rootDir, nuxt.options.rootDir,

4
packages/common/src/hookable.js
View File

@ -34,8 +34,8 @@ export default class Hookable {
try { try {
await sequence(this._hooks[name], fn => fn(...args)) await sequence(this._hooks[name], fn => fn(...args))
} catch (err) { } catch (err) {
consola.error(err) name !== 'error' && this.callHook('error', err)
this.callHook('error', err) consola.fatal(err)
} }
} }

6
test/unit/error.test.js
View File

@ -39,7 +39,7 @@ describe('error', () => {
}) })
test('Error: callHook()', async () => { test('Error: callHook()', async () => {
consola.error.mockClear() consola.fatal.mockClear()
const errorHook = jest.fn() const errorHook = jest.fn()
const error = new Error('test hook error') const error = new Error('test hook error')
@ -50,8 +50,8 @@ describe('error', () => {
expect(errorHook).toHaveBeenCalledTimes(1) expect(errorHook).toHaveBeenCalledTimes(1)
expect(errorHook).toHaveBeenCalledWith(error) expect(errorHook).toHaveBeenCalledWith(error)
expect(consola.error).toHaveBeenCalledTimes(1) expect(consola.fatal).toHaveBeenCalledTimes(1)
expect(consola.error).toHaveBeenCalledWith(error) expect(consola.fatal).toHaveBeenCalledWith(error)
}) })
// Close server and ask nuxt to stop listening to file changes // Close server and ask nuxt to stop listening to file changes