Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-22 13:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(nuxt): apply scoped styles to islands (#23386)

Browse Source
This commit is contained in:
Arsen Goian 2023-09-28 10:36:13 +03:00 committed by GitHub
parent 9da77db358
commit 17e6c1f7fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/nuxt/src/app/components/nuxt-island.ts
View File

@ -50,7 +50,8 @@ export default defineComponent({
const error = ref<unknown>(null) const error = ref<unknown>(null)
const config = useRuntimeConfig() const config = useRuntimeConfig()
const nuxtApp = useNuxtApp() const nuxtApp = useNuxtApp()
const hashId = computed(() => hash([props.name, props.props, props.context, props.source])) const filteredProps = computed(() => props.props ? Object.fromEntries(Object.entries(props.props).filter(([key]) => !key.startsWith('data-v-'))) : {})
const hashId = computed(() => hash([props.name, filteredProps.value, props.context, props.source]))
const instance = getCurrentInstance()! const instance = getCurrentInstance()!
const event = useRequestEvent() const event = useRequestEvent()
// TODO: remove use of `$fetch.raw` when nitro 503 issues on windows dev server are resolved // TODO: remove use of `$fetch.raw` when nitro 503 issues on windows dev server are resolved

3
packages/nuxt/src/components/runtime/server-component.ts
View File

@ -11,8 +11,7 @@ export const createServerComponent = (name: string) => {
return h(NuxtIsland, { return h(NuxtIsland, {
name, name,
lazy: props.lazy, lazy: props.lazy,
// #23051 - remove data-v attributes props: attrs
props: Object.fromEntries(Object.entries(attrs).filter(([key]) => !key.startsWith('data-v-')))
}, slots) }, slots)
} }
} }

2
test/nuxt/nuxt-island.test.ts
View File

@ -31,9 +31,9 @@ describe('runtime server component', () => {
expect(h).toHaveBeenCalledOnce() expect(h).toHaveBeenCalledOnce()
if (!vi.mocked(h).mock.lastCall) { throw new Error('no last call') } if (!vi.mocked(h).mock.lastCall) { throw new Error('no last call') }
expect(vi.mocked(h).mock.lastCall![1]?.props).toBeTypeOf('object') expect(vi.mocked(h).mock.lastCall![1]?.props).toBeTypeOf('object')
expect(Object.keys(vi.mocked(h).mock.lastCall![1]?.props)).not.toContain('data-v-123')
expect(vi.mocked(h).mock.lastCall![1]?.props).toMatchInlineSnapshot(` expect(vi.mocked(h).mock.lastCall![1]?.props).toMatchInlineSnapshot(`
{ {
"data-v-123": "",
"test": 1, "test": 1,
} }
`) `)