From 25fdb28d41291e96888705668c99b12ec1555766 Mon Sep 17 00:00:00 2001 From: Pooya Parsa Date: Sat, 5 Aug 2017 12:13:10 +0430 Subject: [PATCH] more consistent errors --- lib/core/renderer.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/core/renderer.js b/lib/core/renderer.js index 6d94d89926..2590e754e7 100644 --- a/lib/core/renderer.js +++ b/lib/core/renderer.js @@ -277,14 +277,15 @@ export default class Renderer extends Tapable { } errorMiddleware (err, req, res, next) { - // ensure statusCode and message + // ensure statusCode, message and name fields err.statusCode = err.statusCode || 500 err.message = err.message || 'Nuxt Server Error' + err.name = err.name || 'Nuxt Server Error' const sendResponse = (content, type = 'text/html') => { // Set Headers res.statusCode = err.statusCode - res.statusMessage = err.message + res.statusMessage = err.name res.setHeader('Content-Type', type + '; charset=utf-8') res.setHeader('Content-Length', Buffer.byteLength(content)) @@ -301,7 +302,7 @@ export default class Renderer extends Tapable { const json = { status: err.statusCode, message: err.message, - name: 'Nuxt Server Error' + name: err.name } if (isJson) { sendResponse(JSON.stringify(json, undefined, 2), 'text/json') @@ -313,8 +314,6 @@ export default class Renderer extends Tapable { } // Show stack trace - err.name = 'Nuxt Server Error' - err.status = 500 const youch = new Youch(err, req, this.readSource.bind(this)) if (isJson) { youch.toJSON().then(json => { sendResponse(JSON.stringify(json, undefined, 2), 'text/json') })