Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-27 16:12:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct socket address in use error message

Browse Source
This commit is contained in:
Clark Du 2019-03-19 11:19:56 +00:00
parent b675a0623b
commit 2eb1965357
2 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/server/src/listener.js
View File

@ -95,16 +95,17 @@ export default class Listener {
// Use better error message // Use better error message
if (addressInUse) { if (addressInUse) {
error.message = `Address \`${this.host}:${this.port}\` is already in use.` const address = this.socket || `${this.host}:${this.port}`
} error.message = `Address \`${address}\` is already in use.`
// Listen to a random port on dev as a fallback // Listen to a random port on dev as a fallback
if (addressInUse && this.dev && this.port !== '0') { if (this.dev && !this.socket && this.port !== '0') {
consola.warn(error.message) consola.warn(error.message)
consola.info('Trying a random port...') consola.info('Trying a random port...')
this.port = '0' this.port = '0'
return this.close().then(() => this.listen()) return this.close().then(() => this.listen())
} }
}
// Throw error // Throw error
throw error throw error

9
packages/server/test/listener.test.js
View File

@ -330,6 +330,15 @@ describe('server: listener', () => {
expect(() => listener.serverErrorHandler(addressInUse)).toThrow('Address `localhost:3000` is already in use.') expect(() => listener.serverErrorHandler(addressInUse)).toThrow('Address `localhost:3000` is already in use.')
}) })
test('should throw address in use error for socket', () => {
const listener = new Listener({})
listener.socket = 'nuxt.socket'
const addressInUse = new Error()
addressInUse.code = 'EADDRINUSE'
expect(() => listener.serverErrorHandler(addressInUse)).toThrow('Address `nuxt.socket` is already in use.')
})
test('should fallback to a random port in address in use error', async () => { test('should fallback to a random port in address in use error', async () => {
const listener = new Listener({ dev: true }) const listener = new Listener({ dev: true })
listener.host = 'localhost' listener.host = 'localhost'