Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-22 13:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(kit): don't mutate existing component entry when overriding (#25786)

Browse Source
This commit is contained in:
Daniel Roe 2024-02-14 11:48:25 +00:00 committed by GitHub
parent 936ad91b0a
commit 363bb57b63
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/kit/src/components.ts
View File

@ -52,8 +52,9 @@ export async function addComponent (opts: AddComponentOptions) {
} }
nuxt.hook('components:extend', (components: Component[]) => { nuxt.hook('components:extend', (components: Component[]) => {
const existingComponent = components.find(c => (c.pascalName === component.pascalName || c.kebabName === component.kebabName) && c.mode === component.mode) const existingComponentIndex = components.findIndex(c => (c.pascalName === component.pascalName || c.kebabName === component.kebabName) && c.mode === component.mode)
if (existingComponent) { if (existingComponentIndex !== -1) {
const existingComponent = components[existingComponentIndex]
const existingPriority = existingComponent.priority ?? 0 const existingPriority = existingComponent.priority ?? 0
const newPriority = component.priority ?? 0 const newPriority = component.priority ?? 0
@ -65,7 +66,7 @@ export async function addComponent (opts: AddComponentOptions) {
const name = existingComponent.pascalName || existingComponent.kebabName const name = existingComponent.pascalName || existingComponent.kebabName
logger.warn(`Overriding ${name} component. You can specify a \`priority\` option when calling \`addComponent\` to avoid this warning.`) logger.warn(`Overriding ${name} component. You can specify a \`priority\` option when calling \`addComponent\` to avoid this warning.`)
} }
Object.assign(existingComponent, component) components.splice(existingComponentIndex, 1, component)
} else { } else {
components.push(component) components.push(component)
} }