Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-12-02 10:27:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: fail in case of missing core-js dependency (#5342)

Browse Source
This commit is contained in:
Pooya Parsa 2019-03-23 11:18:18 +04:30 committed by GitHub
parent 39bbe46ecb
commit 439b914fd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/builder/src/builder.js
View File

@ -222,7 +222,7 @@ export default class Builder {
'Using npm:\n', 'Using npm:\n',
`npm i ${dependencyFixes.join(' ')}\n` `npm i ${dependencyFixes.join(' ')}\n`
) )
throw new Error('Missing Template Dependencies') throw new Error('Missing App Dependencies')
} }
} }

2
packages/builder/test/builder.build.test.js
View File

@ -263,7 +263,7 @@ describe('builder: builder build', () => {
.mockReturnValueOnce({ version: 'alpha' }) .mockReturnValueOnce({ version: 'alpha' })
.mockReturnValueOnce(undefined) .mockReturnValueOnce(undefined)
expect(() => builder.validateTemplate()).toThrow('Missing Template Dependencies') expect(() => builder.validateTemplate()).toThrow('Missing App Dependencies')
expect(nuxt.resolver.requireModule).toBeCalledTimes(2) expect(nuxt.resolver.requireModule).toBeCalledTimes(2)
expect(nuxt.resolver.requireModule).nthCalledWith(1, 'join(vue, package.json)') expect(nuxt.resolver.requireModule).nthCalledWith(1, 'join(vue, package.json)')

1
packages/vue-app/package.json
View File

@ -12,6 +12,7 @@
"main": "dist/vue-app.js", "main": "dist/vue-app.js",
"typings": "types/index.d.ts", "typings": "types/index.d.ts",
"dependencies": { "dependencies": {
"core-js": "^2.6.5",
"node-fetch": "^2.3.0", "node-fetch": "^2.3.0",
"unfetch": "^4.1.0", "unfetch": "^4.1.0",
"vue": "^2.6.10", "vue": "^2.6.10",