From 47e0721413b1ff64fbc7ef17c5201265f3da0935 Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Tue, 2 Nov 2021 09:43:08 +0000 Subject: [PATCH] fix(nuxi, kit): import individual semver function (#1598) --- packages/kit/src/module/utils.ts | 4 ++-- packages/nuxi/src/utils/engines.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/kit/src/module/utils.ts b/packages/kit/src/module/utils.ts index 996ae8a22b..4017e1fad9 100644 --- a/packages/kit/src/module/utils.ts +++ b/packages/kit/src/module/utils.ts @@ -5,7 +5,7 @@ import hash from 'hash-sum' import type { WebpackPluginInstance, Configuration as WebpackConfig } from 'webpack' import type { Plugin as VitePlugin, UserConfig as ViteConfig } from 'vite' import { camelCase } from 'scule' -import semver from 'semver' +import satisfies from 'semver/functions/satisfies.js' // npm/node-semver#381 import { NuxtCompatibilityConstraints, NuxtCompatibilityIssues } from '../types/module' import { Nuxt } from '../types/nuxt' import { useNuxt } from '../nuxt' @@ -357,7 +357,7 @@ export function checkNuxtCompatibilityIssues (constraints: NuxtCompatibilityCons if (constraints.nuxt) { const nuxtVersion = getNuxtVersion(nuxt) const nuxtSemanticVersion = nuxtVersion.split('-').shift() - if (!semver.satisfies(nuxtSemanticVersion, constraints.nuxt)) { + if (!satisfies(nuxtSemanticVersion, constraints.nuxt)) { issues.push({ name: 'nuxt', message: `Nuxt version \`${constraints.nuxt}\` is required but currently using \`${nuxtVersion}\`` diff --git a/packages/nuxi/src/utils/engines.ts b/packages/nuxi/src/utils/engines.ts index eddd69c4c7..80c2307666 100644 --- a/packages/nuxi/src/utils/engines.ts +++ b/packages/nuxi/src/utils/engines.ts @@ -1,11 +1,11 @@ import { engines } from '../../package.json' export async function checkEngines () { - const semver = await import('semver').then(r => r.default || r) + const satisfies = await import('semver/functions/satisfies.js').then(r => r.default) // npm/node-semver#381 const currentNode = process.versions.node const nodeRange = engines.node - if (!semver.satisfies(process.versions.node, engines.node)) { + if (!satisfies(currentNode, nodeRange)) { console.warn(`Current version of Node.js (\`${currentNode}\`) is unsupported and might cause issues.\n Please upgrade to a compatible version (${nodeRange}).`) } }