fix(nuxt): set to.name to be undefined rather than deleting entirely

This commit is contained in:
Daniel Roe 2024-02-22 12:46:13 +00:00
parent ba6a4132bb
commit 4ca1ab7cfb
No known key found for this signature in database
GPG Key ID: 3714AB03996F442B
2 changed files with 5 additions and 5 deletions

View File

@ -88,7 +88,7 @@ export interface NuxtLinkProps extends Omit<RouterLinkProps, 'to'> {
noPrefetch?: boolean
}
/*@__NO_SIDE_EFFECTS__*/
/*@__NO_SIDE_EFFECTS__*/
export function defineNuxtLink (options: NuxtLinkOptions) {
const componentName = options.componentName || 'NuxtLink'
@ -100,7 +100,6 @@ export function defineNuxtLink (options: NuxtLinkOptions) {
function resolveTrailingSlashBehavior (to: string, resolve: Router['resolve']): string
function resolveTrailingSlashBehavior (to: RouteLocationRaw, resolve: Router['resolve']): Exclude<RouteLocationRaw, string>
function resolveTrailingSlashBehavior (to: undefined, resolve: Router['resolve']): undefined
function resolveTrailingSlashBehavior (to: RouteLocationRaw | undefined, resolve: Router['resolve']): RouteLocationRaw | RouteLocation | undefined {
if (!to || (options.trailingSlash !== 'append' && options.trailingSlash !== 'remove')) {
return to
@ -117,6 +116,7 @@ export function defineNuxtLink (options: NuxtLinkOptions) {
path: applyTrailingSlashBehavior(path, options.trailingSlash)
}
// named routes would otherwise always override trailing slash behavior
if ('name' in resolvedPath) {
delete resolvedPath.name
}
@ -332,8 +332,8 @@ export function defineNuxtLink (options: NuxtLinkOptions) {
const href = typeof to.value === 'object'
? router.resolve(to.value)?.href ?? null
: (to.value && !props.external && !isAbsoluteUrl.value)
? resolveTrailingSlashBehavior(joinURL(config.app.baseURL, to.value), router.resolve) as string
: to.value || null
? resolveTrailingSlashBehavior(joinURL(config.app.baseURL, to.value), router.resolve) as string
: to.value || null
// Resolves `target` value
const target = props.target || null

View File

@ -239,7 +239,7 @@ const plugin: Plugin<{ router: Router }> = defineNuxtPlugin({
try {
const to = router.resolve(initialURL)
// #4920, #4982
if ('name' in to) { delete to.name }
if ('name' in to) { to.name = undefined }
await router.replace({
...to,
force: true