From 531af31af7304fcd863bbfa291e4c7b5d02f0cf6 Mon Sep 17 00:00:00 2001
From: Pooya Parsa <pooya@pi0.ir>
Date: Sat, 17 Mar 2018 13:04:33 +0330
Subject: [PATCH] perf: improve chunk splitting

---
 lib/builder/webpack/base.config.js   | 13 +-----
 lib/builder/webpack/client.config.js | 62 +++++++++++++++++++++++++++-
 lib/common/options.js                |  5 +--
 3 files changed, 64 insertions(+), 16 deletions(-)

diff --git a/lib/builder/webpack/base.config.js b/lib/builder/webpack/base.config.js
index 5da3726934..9f6736bec0 100644
--- a/lib/builder/webpack/base.config.js
+++ b/lib/builder/webpack/base.config.js
@@ -1,4 +1,3 @@
-const ExtractTextPlugin = require('extract-text-webpack-plugin')
 const TimeFixPlugin = require('time-fix-plugin')
 const WarnFixPlugin = require('./plugins/warnfix')
 const ProgressPlugin = require('./plugins/progress')
@@ -45,11 +44,13 @@ module.exports = function webpackBaseConfig({ name, isServer }) {
       path: resolve(this.options.buildDir, 'dist'),
       filename: this.getFileName('app'),
       chunkFilename: this.getFileName('chunk'),
+      jsonpFunction: '_NXT_',
       publicPath: isUrl(this.options.build.publicPath)
         ? this.options.build.publicPath
         : urlJoin(this.options.router.base, this.options.build.publicPath)
     },
     performance: {
+      maxEntrypointSize: 1000 * 1024,
       hints: this.options.dev ? false : 'warning'
     },
     resolve: {
@@ -143,16 +144,6 @@ module.exports = function webpackBaseConfig({ name, isServer }) {
   // Hide warnings about plugins without a default export (#1179)
   config.plugins.push(new WarnFixPlugin())
 
-  // CSS extraction
-  const extractCSS = this.options.build.extractCSS
-  if (extractCSS) {
-    const extractOptions = Object.assign(
-      { filename: this.getFileName('css') },
-      typeof extractCSS === 'object' ? extractCSS : {}
-    )
-    config.plugins.push(new ExtractTextPlugin(extractOptions))
-  }
-
   // Clone deep avoid leaking config between Client and Server
   return cloneDeep(config)
 }
diff --git a/lib/builder/webpack/client.config.js b/lib/builder/webpack/client.config.js
index 754c8053af..533cfd0e03 100644
--- a/lib/builder/webpack/client.config.js
+++ b/lib/builder/webpack/client.config.js
@@ -9,12 +9,18 @@ const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer')
 const { resolve } = require('path')
 const Debug = require('debug')
 const base = require('./base.config.js')
+const ExtractTextPlugin = require('extract-text-webpack-plugin')
 
 const debug = Debug('nuxt:build')
 debug.color = 2 // Force green color
 
+/*
+|--------------------------------------------------------------------------
+| Webpack Client Config
+|--------------------------------------------------------------------------
+*/
 module.exports = function webpackClientConfig() {
-  let config = base.call(this, { name: 'client', isServer: false })
+  const config = base.call(this, { name: 'client', isServer: false })
 
   // Entry points
   config.entry = resolve(this.options.buildDir, 'client.js')
@@ -83,7 +89,59 @@ module.exports = function webpackClientConfig() {
   config.optimization.splitChunks = {
     chunks: 'all',
     // TODO: remove spa after https://github.com/jantimon/html-webpack-plugin/issues/878 solved
-    name: this.options.dev || this.options.mode === 'spa'
+    name: this.options.dev, // || this.options.mode === 'spa',
+
+    // Explicit cache groups
+    cacheGroups: {
+      // Vue.js core modules
+      vue: {
+        test: /node_modules\/(vue|vue-loader|vue-router|vuex|vue-meta)\//,
+        chunks: 'initial',
+        name: 'vue',
+        priority: 10,
+        enforce: true
+      },
+      // Common modules which are usually included in projects
+      common: {
+        test: /node_modules\/(core-js|babel-runtime|lodash|es6-promise|moment|axios|webpack|setimediate|timers-browserify|process)\//,
+        chunks: 'initial',
+        name: 'common',
+        priority: 9
+      },
+      // Generated templates
+      main: {
+        test: /\.nuxt\//,
+        chunks: 'initial',
+        name: 'main',
+        priority: 8
+      },
+      // Other vendors inside node_modules
+      vendor: {
+        test: /node_modules\//,
+        chunks: 'initial',
+        name: 'vendor',
+        priority: 8
+      }
+    }
+  }
+
+  // Create additional runtime chunk for cache boosting
+  config.optimization.runtimeChunk = true
+
+  // CSS extraction
+  const extractCSS = this.options.build.extractCSS
+  if (extractCSS) {
+    config.plugins.push(new ExtractTextPlugin(Object.assign({
+      filename: this.getFileName('css')
+
+      // When using optimization.splitChunks and there are
+      // extracted chunks in the commons chunk,
+      // allChunks *must* be set to true
+      // TODO: For nuxt this makes duplicate css assets!
+      // allChunks: true
+    },
+    typeof extractCSS === 'object' ? extractCSS : {}
+    )))
   }
 
   // --------------------------------------
diff --git a/lib/common/options.js b/lib/common/options.js
index c91d333183..da1cd29824 100644
--- a/lib/common/options.js
+++ b/lib/common/options.js
@@ -204,10 +204,9 @@ Options.defaults = {
     ssr: undefined,
     publicPath: '/_nuxt/',
     filenames: {
-      css: '[name].[contenthash].css',
-      manifest: 'manifest.[hash].js',
       app: '[name].[chunkhash].js',
-      chunk: '[name].[chunkhash].js'
+      chunk: '[name].[chunkhash].js',
+      css: '[name].[contenthash].css'
     },
     styleResources: {},
     plugins: [],