From 63d189a0c7d1d507252b8c1029bbce43710dbdb5 Mon Sep 17 00:00:00 2001
From: Daniel Roe <daniel@roe.dev>
Date: Mon, 11 Sep 2023 14:05:14 +0100
Subject: [PATCH] ci: update fixtures to node 18 (#23122)

---
 .github/workflows/ci.yml | 2 +-
 test/basic.test.ts       | 7 +------
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 47a554bd33..720c991260 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -170,7 +170,7 @@ jobs:
         env: ['dev', 'built']
         builder: ['vite', 'webpack']
         context: ['async', 'default']
-        node: [16]
+        node: [18]
         exclude:
           - env: 'dev'
             builder: 'webpack'
diff --git a/test/basic.test.ts b/test/basic.test.ts
index 152b812d84..b048d1fe7f 100644
--- a/test/basic.test.ts
+++ b/test/basic.test.ts
@@ -751,12 +751,7 @@ describe('errors', () => {
 
   it('should render a HTML error page', async () => {
     const res = await fetch('/error')
-    // TODO: remove when we update CI to node v18
-    if (process.version.startsWith('v16')) {
-      expect(res.headers.get('Set-Cookie')).toBe('set-in-plugin=true; Path=/')
-    } else {
-      expect(res.headers.get('Set-Cookie')).toBe('set-in-plugin=true; Path=/, some-error=was%20set; Path=/')
-    }
+    expect(res.headers.get('Set-Cookie')).toBe('set-in-plugin=true; Path=/, some-error=was%20set; Path=/')
     expect(await res.text()).toContain('This is a custom error')
   })