Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-11 08:33:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: warn when styleResources is used without the community module (#4302)

Browse Source 
[skip ci]
This commit is contained in:
Alexander Lichter 2018-11-09 23:59:40 +00:00 committed by Pooya Parsa
parent 18e613106b
commit 692493f5aa
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/webpack/src/builder.js
View File

@ -76,6 +76,12 @@ export class WebpackBundler {
// Check styleResource existence // Check styleResource existence
const styleResources = this.context.options.build.styleResources const styleResources = this.context.options.build.styleResources
if (styleResources && Object.keys(styleResources).length) {
consola.warn(
'Using styleResources without the nuxt-style-resources-module is not suggested and can lead to severe performance issues.',
'Please use https://github.com/nuxt-community/style-resources-module'
)
}
Object.keys(styleResources).forEach(async (ext) => { Object.keys(styleResources).forEach(async (ext) => {
await Promise.all(wrapArray(styleResources[ext]).map(async (p) => { await Promise.all(wrapArray(styleResources[ext]).map(async (p) => {
const styleResourceFiles = await glob(path.resolve(this.context.options.rootDir, p)) const styleResourceFiles = await glob(path.resolve(this.context.options.rootDir, p))

6
test/fixtures/with-config/with-config.test.js vendored
View File

@ -14,13 +14,17 @@ const hooks = [
describe('with-config', () => { describe('with-config', () => {
buildFixture('with-config', () => { buildFixture('with-config', () => {
expect(consola.warn).toHaveBeenCalledTimes(2) expect(consola.warn).toHaveBeenCalledTimes(3)
expect(consola.fatal).toHaveBeenCalledTimes(0) expect(consola.fatal).toHaveBeenCalledTimes(0)
expect(consola.warn.mock.calls).toMatchObject([ expect(consola.warn.mock.calls).toMatchObject([
[{ [{
message: 'Found 2 plugins that match the configuration, suggest to specify extension:', message: 'Found 2 plugins that match the configuration, suggest to specify extension:',
additional: expect.stringContaining('plugins/test.json') additional: expect.stringContaining('plugins/test.json')
}], }],
[
'Using styleResources without the nuxt-style-resources-module is not suggested and can lead to severe performance issues.',
'Please use https://github.com/nuxt-community/style-resources-module'
],
[ [
'Notice: Please do not deploy bundles built with analyze mode, it\'s only for analyzing purpose.' 'Notice: Please do not deploy bundles built with analyze mode, it\'s only for analyzing purpose.'
] ]