From 6ae7718a42f28b4df0dc45a45f7655706089562b Mon Sep 17 00:00:00 2001
From: "Xin Du (Clark)" <clark.duxin@gmail.com>
Date: Sun, 9 Feb 2020 11:17:39 +0000
Subject: [PATCH] fix(utils): eliminate side effect from modern utils (#6953)

[release]
---
 packages/utils/src/modern.js | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/packages/utils/src/modern.js b/packages/utils/src/modern.js
index 52dcc4ae19..3f304bdd5e 100644
--- a/packages/utils/src/modern.js
+++ b/packages/utils/src/modern.js
@@ -1,6 +1,3 @@
-import UAParser from 'ua-parser-js'
-import semver from 'semver'
-
 export const ModernBrowsers = {
   Edge: '16',
   Firefox: '60',
@@ -15,22 +12,29 @@ export const ModernBrowsers = {
   'Mobile Safari': '10.3'
 }
 
-const modernBrowsers = Object.keys(ModernBrowsers)
-  .reduce((allBrowsers, browser) => {
-    allBrowsers[browser] = semver.coerce(ModernBrowsers[browser])
-    return allBrowsers
-  }, {})
+const modernBrowsers = new Proxy(ModernBrowsers, {
+  get (browsers, prop) {
+    if (browsers[prop] && !browsers[prop].version) {
+      const coerce = require('semver/functions/coerce')
+      browsers[prop] = coerce(browsers[prop])
+    }
+    return browsers[prop]
+  }
+})
 
 export const isModernBrowser = (ua) => {
   if (!ua) {
     return false
   }
+  const coerce = require('semver/functions/coerce')
+  const gte = require('semver/functions/gte')
+  const UAParser = require('ua-parser-js')
   const { browser } = UAParser(ua)
-  const browserVersion = semver.coerce(browser.version)
+  const browserVersion = coerce(browser.version)
   if (!browserVersion) {
     return false
   }
-  return Boolean(modernBrowsers[browser.name] && semver.gte(browserVersion, modernBrowsers[browser.name]))
+  return Boolean(modernBrowsers[browser.name] && gte(browserVersion, modernBrowsers[browser.name]))
 }
 
 export const isModernRequest = (req, modernMode = false) => {