From 783ef46cff2af8cd3519366189368ed6715a2c88 Mon Sep 17 00:00:00 2001 From: Clark Du Date: Fri, 31 Aug 2018 20:48:33 +0100 Subject: [PATCH] refactor: simplify package.js --- build/package.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/build/package.js b/build/package.js index d326e32524..a1972cb531 100644 --- a/build/package.js +++ b/build/package.js @@ -71,9 +71,9 @@ export default class Package extends EventEmitter { this.packageObj.version = `${baseVersion}-${date}.${gitCommit}` } - convertToEdge() { + convertTo(suffix) { this.logger.info('Converting to edge package') - this.addNameSuffix('-edge') + this.addNameSuffix(`-${suffix}`) this.generateVersion() this.writePackage() } @@ -88,7 +88,7 @@ export default class Package extends EventEmitter { this.emit('build:before') if (this.edge) { - this.convertToEdge() + this.convertTo('edge') } this.logger.info('Cleaning up') @@ -112,11 +112,7 @@ export default class Package extends EventEmitter { } copyFilesFrom(source, files) { - if (!files) { - files = source.packageObj.files || [] - } - - for (const file of files) { + for (const file of files || source.packageObj.files || []) { const src = resolve(source.rootDir, file) const dst = resolve(this.rootDir, file) copySync(src, dst)