fix(utils): support chaining functions with promise (#8038)

This commit is contained in:
pooya parsa 2020-09-09 09:22:43 +00:00 committed by GitHub
parent 6828ba9184
commit 7961e539da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 17 deletions

View File

@ -13,24 +13,28 @@ export const chainFn = function chainFn (base, fn) {
if (typeof fn !== 'function') {
return base
}
return function (...args) {
if (typeof base !== 'function') {
return fn.apply(this, args)
return fn
}
let baseResult = base.apply(this, args)
// Allow function to mutate the first argument instead of returning the result
if (baseResult === undefined) {
[baseResult] = args
return function (arg0, ...args) {
const next = (previous = arg0) => {
const fnResult = fn.call(this, previous, ...args)
if (fnResult && typeof fnResult.then === 'function') {
return fnResult.then(res => res || previous)
}
const fnResult = fn.call(
this,
baseResult,
...Array.prototype.slice.call(args, 1)
)
// Return mutated argument if no result was returned
if (fnResult === undefined) {
return baseResult
return fnResult || previous
}
return fnResult
const baseResult = base.call(this, arg0, ...args)
if (baseResult && typeof baseResult.then === 'function') {
return baseResult.then(res => next(res))
}
return next(baseResult)
}
}

View File

@ -103,4 +103,15 @@ describe('util: task', () => {
const chainedFn = chainFn(firstFn, secondFn)
expect(chainedFn({}, 10)).toEqual({ bar: 12 })
})
test('chainFn (promise)', async () => {
const firstFn = () => Promise.resolve({ foo: 1 })
const secondFn = function (obj) {
obj.foo++
return Promise.resolve()
}
const chainedFn = chainFn(firstFn, secondFn)
expect(await chainedFn()).toEqual({ foo: 2 })
})
})