Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-26 07:32:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(bridge): define mixin outside plugin, to avoid memory leak (#3900)

Browse Source
This commit is contained in:
Daniel Roe 2022-03-25 12:51:07 +00:00 committed by GitHub
parent 38e92597f4
commit 7c1a8ae0d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/nuxt3/src/meta/runtime/plugin.ts
View File

@ -1,7 +1,7 @@
import { computed, getCurrentInstance } from 'vue' import { computed, getCurrentInstance } from 'vue'
import * as Components from './components' import * as Components from './components'
import { useMeta } from './composables' import { useMeta } from './composables'
import { defineNuxtPlugin } from '#app' import { defineNuxtPlugin, useNuxtApp } from '#app'
// @ts-ignore // @ts-ignore
import metaConfig from '#build/meta.config.mjs' import metaConfig from '#build/meta.config.mjs'
@ -10,13 +10,11 @@ declare module 'vue' {
export interface GlobalComponents extends MetaComponents {} export interface GlobalComponents extends MetaComponents {}
} }
export default defineNuxtPlugin((nuxtApp) => { const metaMixin = {
useMeta(metaConfig.globalMeta)
nuxtApp.vueApp.mixin({
[metaConfig.mixinKey] () { [metaConfig.mixinKey] () {
const instance = getCurrentInstance() const instance = getCurrentInstance()
const options = instance?.type || /* nuxt2 */ instance?.proxy?.$options const options = instance?.type || /* nuxt2 */ instance?.proxy?.$options
const nuxtApp = useNuxtApp()
if (!options || !('head' in options)) { return } if (!options || !('head' in options)) { return }
const source = typeof options.head === 'function' const source = typeof options.head === 'function'
@ -25,7 +23,12 @@ export default defineNuxtPlugin((nuxtApp) => {
useMeta(source) useMeta(source)
} }
}) }
export default defineNuxtPlugin((nuxtApp) => {
useMeta(metaConfig.globalMeta)
nuxtApp.vueApp.mixin(metaMixin)
for (const name in Components) { for (const name in Components) {
// eslint-disable-next-line import/namespace // eslint-disable-next-line import/namespace