From 7fcbd5aa3be7b19699e9077fdb76f1b6304d9c92 Mon Sep 17 00:00:00 2001
From: Clark Du <clark.duxin@gmail.com>
Date: Sun, 26 Nov 2017 21:40:57 +0800
Subject: [PATCH] fix: add v-bind:key in all v-for

---
 examples/async-data/pages/posts/index.vue     | 2 +-
 examples/custom-routes/pages/index.vue        | 2 +-
 examples/middleware/components/Visits.vue     | 2 +-
 examples/middleware/pages/_slug.vue           | 4 +++-
 examples/nested-routes/pages/index.vue        | 2 +-
 examples/routes-transitions/pages/users.vue   | 2 +-
 examples/typescript/pages/index.vue           | 2 +-
 examples/vue-apollo/pages/index.vue           | 2 +-
 examples/vuex-store-modules/pages/todos.vue   | 2 +-
 examples/vuex-store-modules/pages/website.vue | 4 ++--
 examples/with-cookies/pages/index.vue         | 2 +-
 examples/with-firebase/pages/index.vue        | 2 +-
 examples/with-sockets/pages/index.vue         | 4 +++-
 13 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/examples/async-data/pages/posts/index.vue b/examples/async-data/pages/posts/index.vue
index 6a7014d4ed..1015972fa8 100644
--- a/examples/async-data/pages/posts/index.vue
+++ b/examples/async-data/pages/posts/index.vue
@@ -3,7 +3,7 @@
   <div class="container">
     <h1>Blog</h1>
     <ul>
-      <li v-for="post in posts">
+      <li v-for="(post, index) in posts" :key="index">
         <nuxt-link :to="{ name: 'posts-id', params: { id: post.id } }">{{ post.title }}</nuxt-link>
       </li>
     </ul>
diff --git a/examples/custom-routes/pages/index.vue b/examples/custom-routes/pages/index.vue
index 7febff502d..889363ca7c 100644
--- a/examples/custom-routes/pages/index.vue
+++ b/examples/custom-routes/pages/index.vue
@@ -2,7 +2,7 @@
   <div class="container">
     <h2>Users</h2>
     <ul class="users">
-      <li v-for="user in users">
+      <li v-for="user in users" :key="user.id">
         <nuxt-link :to="'/users/'+user.id">{{ user.name }}</nuxt-link>
       </li>
     </ul>
diff --git a/examples/middleware/components/Visits.vue b/examples/middleware/components/Visits.vue
index 6316ad9c5e..2600db2ba0 100644
--- a/examples/middleware/components/Visits.vue
+++ b/examples/middleware/components/Visits.vue
@@ -1,6 +1,6 @@
 <template>
   <ul>
-    <li v-for="visit in visits"><i>{{ visit.date | hours }}</i> - {{ visit.path }}</li>
+    <li v-for="(visit, index) in visits" :key="index"><i>{{ visit.date | hours }}</i> - {{ visit.path }}</li>
   </ul>
 </template>
 
diff --git a/examples/middleware/pages/_slug.vue b/examples/middleware/pages/_slug.vue
index 30d4649eac..7542d78473 100644
--- a/examples/middleware/pages/_slug.vue
+++ b/examples/middleware/pages/_slug.vue
@@ -4,7 +4,9 @@
     <pre>{{ userAgent }}</pre>
     <ul>
       <li><nuxt-link to="/">Home</nuxt-link></li>
-      <li v-for="slug in slugs"><nuxt-link :to="{ name: 'slug', params: { slug } }">{{ slug }}</nuxt-link></li>
+      <li v-for="(slug, index) in slugs" :key="index">
+        <nuxt-link :to="{ name: 'slug', params: { slug } }">{{ slug }}</nuxt-link>
+      </li>
     </ul>
   </div>
 </template>
diff --git a/examples/nested-routes/pages/index.vue b/examples/nested-routes/pages/index.vue
index 82d8bd3643..5a98a4417b 100644
--- a/examples/nested-routes/pages/index.vue
+++ b/examples/nested-routes/pages/index.vue
@@ -3,7 +3,7 @@
     <div class="left">
       <h2><nuxt-link to="/">Players</nuxt-link></h2>
       <ul class="players">
-        <li v-for="user in users">
+        <li v-for="user in users" :key="user.id">
           <nuxt-link :to="'/'+user.id">{{ user.name }}</nuxt-link>
         </li>
       </ul>
diff --git a/examples/routes-transitions/pages/users.vue b/examples/routes-transitions/pages/users.vue
index a02582e753..29cade784e 100644
--- a/examples/routes-transitions/pages/users.vue
+++ b/examples/routes-transitions/pages/users.vue
@@ -6,7 +6,7 @@
     <nuxt-link v-if="page < totalPages" :to="'?page=' + (page + 1)">Next &gt;</nuxt-link>
     <a v-else class="disabled">Next &gt;</a>
     <ul>
-      <li v-for="user in users">
+      <li v-for="user in users" :key="user.id">
         <img :src="user.avatar" class="avatar" />
         <span>{{ user.first_name }} {{ user.last_name }}</span>
       </li>
diff --git a/examples/typescript/pages/index.vue b/examples/typescript/pages/index.vue
index bb135477b7..567e415ebc 100644
--- a/examples/typescript/pages/index.vue
+++ b/examples/typescript/pages/index.vue
@@ -6,7 +6,7 @@
       {{selected}}
     </div>
     <div class="flex flex-wrap ph2 justify-between bg-white-80">
-      <div v-for="person in people">
+      <div v-for="person in people" :key="person.id">
         <Card :person="person"></Card>
       </div>
     </div>
diff --git a/examples/vue-apollo/pages/index.vue b/examples/vue-apollo/pages/index.vue
index 5aa6f9a5cd..6c6e440d36 100644
--- a/examples/vue-apollo/pages/index.vue
+++ b/examples/vue-apollo/pages/index.vue
@@ -2,7 +2,7 @@
   <div>
     <h3>Cars</h3>
     <ul>
-      <li v-for="car in allCars">
+      <li v-for="car in allCars" :key="car.id">
         <nuxt-link :to="`car/${car.id}`">
           {{ car.year }} {{ car.make }} {{ car.model }}
         </nuxt-link>
diff --git a/examples/vuex-store-modules/pages/todos.vue b/examples/vuex-store-modules/pages/todos.vue
index 3c21b92a22..8a693afb95 100644
--- a/examples/vuex-store-modules/pages/todos.vue
+++ b/examples/vuex-store-modules/pages/todos.vue
@@ -2,7 +2,7 @@
   <div>
     <h2>Todos</h2>
     <ul>
-      <li v-for="todo in todos">
+      <li v-for="(todo, index) in todos" :key="index">
         <input type="checkbox" :checked="todo.done" @change="toggle(todo)">
         <span :class="{ done: todo.done }">{{ todo.text }}</span>
       </li>
diff --git a/examples/vuex-store-modules/pages/website.vue b/examples/vuex-store-modules/pages/website.vue
index e0fa75320c..3a8b7d6bd5 100644
--- a/examples/vuex-store-modules/pages/website.vue
+++ b/examples/vuex-store-modules/pages/website.vue
@@ -2,13 +2,13 @@
   <div>
     <h2>Articles</h2>
     <ul>
-      <li v-for="article in articles">
+      <li v-for="(article, index) in articles" :key="index">
         <span>{{article}}</span>
       </li>
     </ul>
     <h2>Comments <small>(nested under articles)</small></h2>
     <ul>
-      <li v-for="comment in comments">
+      <li v-for="(comment, index) in comments" :key="index">
         <span>{{comment}}</span>
       </li>
     </ul>
diff --git a/examples/with-cookies/pages/index.vue b/examples/with-cookies/pages/index.vue
index 7709bec946..429dbc9051 100755
--- a/examples/with-cookies/pages/index.vue
+++ b/examples/with-cookies/pages/index.vue
@@ -8,7 +8,7 @@
         </tr>
       </thead>
       <tbody>
-        <tr v-for="(value, key) in cookies">
+        <tr v-for="(value, key) in cookies" :key="key">
           <td>{{ key }}</td>
           <td>{{ value }}</td>
           <td><button @click="removeCookie(key)">Remove</button></td>
diff --git a/examples/with-firebase/pages/index.vue b/examples/with-firebase/pages/index.vue
index 3ad24b3797..7168ef1231 100644
--- a/examples/with-firebase/pages/index.vue
+++ b/examples/with-firebase/pages/index.vue
@@ -10,7 +10,7 @@
         </tr>
       </thead>
       <tbody>
-        <tr v-for="(user, key) in users">
+        <tr v-for="(user, key) in users" :key="key">
           <td>
             <nuxt-link :to="{ path: `/users/${key}`}">
               <img :src="user.avatar" class="rounded" alt="avatar">
diff --git a/examples/with-sockets/pages/index.vue b/examples/with-sockets/pages/index.vue
index 7184116d06..7e96f5e16b 100644
--- a/examples/with-sockets/pages/index.vue
+++ b/examples/with-sockets/pages/index.vue
@@ -4,7 +4,9 @@
       <li class="chat page">
         <div class="chatArea">
           <ul class="messages" ref="messages">
-            <li class="message" v-for="message in messages"><i :title="message.date">{{ message.date.split('T')[1].slice(0, -2) }}</i>: {{ message.text }}</li>
+            <li class="message" v-for="(message, index) in messages" :key="index">
+              <i :title="message.date">{{ message.date.split('T')[1].slice(0, -2) }}</i>: {{ message.text }}
+            </li>
           </ul>
         </div>
         <input class="inputMessage" type="text" v-model="message" @keyup.enter="sendMessage" placeholder="Type here..." />