From 9c9d519576a529fb3413505503e34d3e19f1832d Mon Sep 17 00:00:00 2001 From: "Xin Du (Clark)" Date: Wed, 16 Jan 2019 17:50:45 +0000 Subject: [PATCH] refactor: simplify return value in addModule (#4766) --- packages/core/src/module.js | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/packages/core/src/module.js b/packages/core/src/module.js index 3b1d43c8d3..baf85c029c 100644 --- a/packages/core/src/module.js +++ b/packages/core/src/module.js @@ -111,7 +111,7 @@ export default class ModuleContainer { return this.addModule(moduleOpts, true /* require once */) } - addModule(moduleOpts, requireOnce) { + async addModule(moduleOpts, requireOnce) { let src let options let handler @@ -157,17 +157,7 @@ export default class ModuleContainer { options = {} } - return new Promise((resolve) => { - // Call module with `this` context and pass options - const result = handler.call(this, options) - - // If module send back a promise - if (result && result.then) { - return resolve(result) - } - - // synchronous - return resolve() - }) + const result = await handler.call(this, options) + return result } }