From adc6884ed1db2ca7ff3a9e44eafced598a42e1b4 Mon Sep 17 00:00:00 2001
From: Clark Du <clark.duxin@gmail.com>
Date: Mon, 20 Nov 2017 12:22:30 +0800
Subject: [PATCH] test: externals and deprecated dev in build.extend

---
 test/fixtures/with-config/nuxt.config.js |  6 ++++++
 test/with-config.test.js                 | 15 +++++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/test/fixtures/with-config/nuxt.config.js b/test/fixtures/with-config/nuxt.config.js
index 44ec31ec13..5454ed2a36 100644
--- a/test/fixtures/with-config/nuxt.config.js
+++ b/test/fixtures/with-config/nuxt.config.js
@@ -1,3 +1,5 @@
+const path = require('path')
+
 module.exports = {
   srcDir: __dirname,
   router: {
@@ -14,6 +16,7 @@ module.exports = {
       ]
     }
   },
+  modulesDir: path.join(__dirname, '..', '..', '..', 'node_modules'),
   transition: 'test',
   layoutTransition: 'test',
   offline: true,
@@ -43,6 +46,9 @@ module.exports = {
       generateStatsFile: true
     },
     extend(config, options) {
+      if (options.dev) {
+        // Please use isDev instead of dev
+      }
       return Object.assign({}, config, {
         devtool: 'nosources-source-map'
       })
diff --git a/test/with-config.test.js b/test/with-config.test.js
index 1f6453f6bc..20c3a25bab 100644
--- a/test/with-config.test.js
+++ b/test/with-config.test.js
@@ -1,5 +1,6 @@
 import test from 'ava'
 import { resolve } from 'path'
+import stdMocks from 'std-mocks'
 import rp from 'request-promise-native'
 import { Nuxt, Builder } from '../index.js'
 
@@ -7,6 +8,7 @@ const port = 4007
 const url = (route) => 'http://localhost:' + port + route
 
 let nuxt = null
+let builtErr = null
 
 // Init nuxt.js and create server listening on localhost:4000
 test.before('Init Nuxt.js', async t => {
@@ -15,7 +17,14 @@ test.before('Init Nuxt.js', async t => {
   config.rootDir = rootDir
   config.dev = false
   nuxt = new Nuxt(config)
+
+  stdMocks.use({
+    stdout: false,
+    stderr: true
+  })
   await new Builder(nuxt).build()
+  stdMocks.restore()
+  builtErr = stdMocks.flush().stderr
 
   await nuxt.listen(port, 'localhost')
 })
@@ -124,6 +133,12 @@ test('Check /test.txt should return 404', async t => {
   t.is(err.response.statusCode, 404)
 })
 
+test('Check deprecated dev in build.extend()', async t => {
+  const deprecatedMsg = 'dev has been deprecated in build.extend(), please use isDev\n'
+  const errors = builtErr.filter(value => value === deprecatedMsg)
+  t.true(errors.length === 2)
+})
+
 // Close server and ask nuxt to stop listening to file changes
 test.after('Closing server and nuxt.js', t => {
   nuxt.close()