From c1bbc5fcd4b2ae489eb0be2355e992a558fdeddd Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Mon, 16 Oct 2023 22:23:38 +0100 Subject: [PATCH] ci: use node 18 for ci jobs (#23701) --- .github/workflows/test.yml | 44 ++++++++++---------- .github/workflows/windows.yml | 20 ++++----- packages/server/test/middleware/nuxt.test.js | 4 +- test/dev/basic.dev.test.js | 4 +- test/dev/basic.dynamic.test.js | 2 +- test/dev/basic.generate.test.js | 2 +- test/dev/basic.plugins.test.js | 4 +- test/dev/basic.relative.test.js | 4 +- test/dev/basic.ssr.csp.test.js | 2 +- test/dev/basic.ssr.test.js | 2 +- test/dev/children.test.js | 4 +- test/dev/cli.test.js | 2 +- test/dev/custom-dirs.test.js | 4 +- test/dev/dist-options.test.js | 2 +- test/dev/encoding.test.js | 4 +- test/dev/error.test.js | 4 +- test/dev/express.test.js | 2 +- test/dev/fallback.test.js | 4 +- test/dev/filenames-query-part.test.js | 2 +- test/dev/full-static-with-preview.test.js | 2 +- test/dev/full-static.test.js | 2 +- test/dev/modern.client.test.js | 4 +- test/dev/modern.server.test.js | 4 +- test/dev/modern.spa.test.js | 4 +- test/dev/module.test.js | 4 +- test/dev/nuxt.test.js | 2 +- test/dev/postcss-function.test.js | 2 +- test/dev/runtime-config.test.js | 2 +- test/dev/server.listen.test.js | 10 ++--- test/dev/spa.test.js | 4 +- test/dev/ssr.test.js | 4 +- test/dev/trailing-slash-payload.test.js | 2 +- test/dev/trailing-slash.test.js | 2 +- test/dev/with-config.test.js | 4 +- test/e2e/basic.browser.test.js | 4 +- test/e2e/basic.navigation.test.js | 4 +- test/e2e/basic.vue-config.test.js | 4 +- test/e2e/children.patch.browser.test.js | 4 +- test/e2e/error.test.js | 4 +- test/e2e/fetch.browser.test.js | 4 +- test/e2e/page-transitions.browser.test.js | 4 +- test/e2e/spa-base.browser.test.js | 4 +- test/e2e/split-layouts-error.test.js | 4 +- test/fixtures/basic/pages/fetch.vue | 2 +- 44 files changed, 103 insertions(+), 103 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1ec93f85b5..f9a5caebd6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -34,7 +34,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: fetch tags @@ -51,7 +51,7 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} lint: runs-on: ${{ matrix.os }} @@ -65,7 +65,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -76,7 +76,7 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: lint run: yarn test:lint @@ -100,7 +100,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -111,7 +111,7 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: audit run: yarn run audit @@ -130,7 +130,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -141,7 +141,7 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: test unit run: yarn test:unit --coverage @@ -169,7 +169,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -180,7 +180,7 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: build run: yarn test:fixtures -i @@ -188,7 +188,7 @@ jobs: - name: Save fixtures uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3 with: - name: fixtures-${{ matrix.os }}-node-v16 + name: fixtures-${{ matrix.os }}-node-v18 path: test/fixtures needs: setup @@ -204,7 +204,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -215,12 +215,12 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: restore fixtures uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2 with: - name: fixtures-${{ matrix.os }}-node-v16 + name: fixtures-${{ matrix.os }}-node-v18 path: test/fixtures - name: lint app @@ -240,7 +240,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -251,12 +251,12 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: restore fixtures uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2 with: - name: fixtures-${{ matrix.os }}-node-v16 + name: fixtures-${{ matrix.os }}-node-v18 path: test/fixtures - name: test dev @@ -276,7 +276,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -287,12 +287,12 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: restore fixtures uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2 with: - name: fixtures-${{ matrix.os }}-node-v16 + name: fixtures-${{ matrix.os }}-node-v18 path: test/fixtures - name: test e2e @@ -325,11 +325,11 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" registry-url: "https://registry.npmjs.org" diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index f9de80c324..9c6a7857a1 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -31,7 +31,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: install @@ -45,7 +45,7 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} test-unit: runs-on: ${{ matrix.os }} @@ -62,7 +62,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -73,7 +73,7 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: test unit run: yarn test:unit --testPathIgnorePatterns=packages/cli @@ -95,7 +95,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -106,7 +106,7 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: build run: yarn test:fixtures @@ -114,7 +114,7 @@ jobs: - name: Save fixtures uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3 with: - name: fixtures-${{ matrix.os }}-node-v16 + name: fixtures-${{ matrix.os }}-node-v18 path: test/fixtures needs: setup @@ -133,7 +133,7 @@ jobs: - run: corepack enable - uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: - node-version: 16 + node-version: 18 cache: "yarn" - name: restore workspace cache @@ -144,12 +144,12 @@ jobs: packages/*/node_modules distributions/*/node_modules packages/*/dist - key: ${{ matrix.os }}-node-v16-nuxt-${{ github.sha }} + key: ${{ matrix.os }}-node-v18-nuxt-${{ github.sha }} - name: restore fixtures uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2 with: - name: fixtures-${{ matrix.os }}-node-v16 + name: fixtures-${{ matrix.os }}-node-v18 path: test/fixtures - name: test dev diff --git a/packages/server/test/middleware/nuxt.test.js b/packages/server/test/middleware/nuxt.test.js index 46384cca53..3a51ffd6fb 100644 --- a/packages/server/test/middleware/nuxt.test.js +++ b/packages/server/test/middleware/nuxt.test.js @@ -20,7 +20,7 @@ const createContext = () => ({ }) const createServerContext = () => ({ - req: { headers: {}, url: 'http://localhost/test/server' }, + req: { headers: {}, url: 'http://127.0.0.1/test/server' }, res: { headers: {}, setHeader: jest.fn(), end: jest.fn() }, next: jest.fn() }) @@ -339,7 +339,7 @@ describe('server: nuxtMiddleware', () => { for (const path of paths) { await nuxtMiddleware( - { ...req, url: 'http://localhost/test/server/' + path }, + { ...req, url: 'http://127.0.0.1/test/server/' + path }, res, next ) diff --git a/test/dev/basic.dev.test.js b/test/dev/basic.dev.test.js index 458beafd3f..97167653bd 100644 --- a/test/dev/basic.dev.test.js +++ b/test/dev/basic.dev.test.js @@ -4,7 +4,7 @@ import consola from 'consola' import { Builder, BundleBuilder, getPort, loadFixture, Nuxt, rp, waitFor } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let builder = null @@ -72,7 +72,7 @@ describe('basic dev', () => { await waitFor(2000) // TODO: Find a better way port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('Check build:done hook called', () => { diff --git a/test/dev/basic.dynamic.test.js b/test/dev/basic.dynamic.test.js index a3102a459b..dc7b5a3091 100644 --- a/test/dev/basic.dynamic.test.js +++ b/test/dev/basic.dynamic.test.js @@ -23,7 +23,7 @@ const resourceLoader = new ProxyLoader() let port let nuxt -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route describe('basic ssr', () => { beforeAll(async () => { diff --git a/test/dev/basic.generate.test.js b/test/dev/basic.generate.test.js index a7086c72c5..5541f08c8b 100644 --- a/test/dev/basic.generate.test.js +++ b/test/dev/basic.generate.test.js @@ -8,7 +8,7 @@ import { TARGETS } from '@nuxt/utils' import { Builder, Generator, getPort, loadFixture, Nuxt, rp, listPaths, equalOrStartsWith } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const rootDir = resolve(__dirname, '..', 'fixtures/basic') const distDir = resolve(rootDir, '.nuxt-generate') diff --git a/test/dev/basic.plugins.test.js b/test/dev/basic.plugins.test.js index c7b7f2eb47..4ee4268e0e 100644 --- a/test/dev/basic.plugins.test.js +++ b/test/dev/basic.plugins.test.js @@ -1,7 +1,7 @@ import { getPort, loadFixture, Nuxt } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null @@ -12,7 +12,7 @@ describe('plugins', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('/', async () => { diff --git a/test/dev/basic.relative.test.js b/test/dev/basic.relative.test.js index 92ea889147..a9487f8bf2 100644 --- a/test/dev/basic.relative.test.js +++ b/test/dev/basic.relative.test.js @@ -2,7 +2,7 @@ import { loadFixture, getPort, Nuxt, rp } from '../utils' let port let nuxt -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const tests = [ ['relative publicPath can be used in dev ssr', { @@ -25,7 +25,7 @@ describe('basic ssr with relative path', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') const { html } = await nuxt.server.renderRoute('/') diff --git a/test/dev/basic.ssr.csp.test.js b/test/dev/basic.ssr.csp.test.js index 63189b48a7..18429132c8 100644 --- a/test/dev/basic.ssr.csp.test.js +++ b/test/dev/basic.ssr.csp.test.js @@ -1,7 +1,7 @@ import { getPort, loadFixture, Nuxt, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const startCspServer = async (csp, isProduction = true) => { const options = await loadFixture('basic', { diff --git a/test/dev/basic.ssr.test.js b/test/dev/basic.ssr.test.js index 646bafd1bb..bf02b989d6 100644 --- a/test/dev/basic.ssr.test.js +++ b/test/dev/basic.ssr.test.js @@ -2,7 +2,7 @@ import consola from 'consola' import { loadFixture, getPort, Nuxt, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null diff --git a/test/dev/children.test.js b/test/dev/children.test.js index 500a119927..08cb7a38ef 100644 --- a/test/dev/children.test.js +++ b/test/dev/children.test.js @@ -1,7 +1,7 @@ import { loadFixture, getPort, Nuxt } from '../utils' let port -// const url = (route) => 'http://localhost:' + port + route +// const url = (route) => 'http://127.0.0.1:' + port + route let nuxt = null @@ -12,7 +12,7 @@ describe('children', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('/parent', async () => { diff --git a/test/dev/cli.test.js b/test/dev/cli.test.js index 0e53d327cc..37526e12f6 100644 --- a/test/dev/cli.test.js +++ b/test/dev/cli.test.js @@ -6,7 +6,7 @@ import { getPort, rp, waitFor } from '../utils' let port const rootDir = resolve(__dirname, '..', 'fixtures/cli') -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const nuxtBin = resolve(__dirname, '../../packages/cli/bin/nuxt-cli.js') const spawnNuxt = (command, opts) => spawn(nuxtBin, [command, rootDir], opts) diff --git a/test/dev/custom-dirs.test.js b/test/dev/custom-dirs.test.js index bd90c012c6..7812374707 100644 --- a/test/dev/custom-dirs.test.js +++ b/test/dev/custom-dirs.test.js @@ -4,7 +4,7 @@ import fs from 'fs' import { getPort, loadFixture, Nuxt, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null @@ -15,7 +15,7 @@ describe('custom-dirs', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('custom assets directory', async () => { diff --git a/test/dev/dist-options.test.js b/test/dev/dist-options.test.js index 4253306a8d..0b9d235d13 100644 --- a/test/dev/dist-options.test.js +++ b/test/dev/dist-options.test.js @@ -1,7 +1,7 @@ import { loadFixture, getPort, Nuxt, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null diff --git a/test/dev/encoding.test.js b/test/dev/encoding.test.js index 714fd0ad4d..5f81ce8812 100644 --- a/test/dev/encoding.test.js +++ b/test/dev/encoding.test.js @@ -2,7 +2,7 @@ import fetch from 'node-fetch-native' import { getPort, loadFixture, Nuxt, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + encodeURI(route) +const url = route => 'http://127.0.0.1:' + port + encodeURI(route) let nuxt = null @@ -13,7 +13,7 @@ describe('encoding', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('/รถ/ (router base)', async () => { diff --git a/test/dev/error.test.js b/test/dev/error.test.js index d6653f5bc6..724b08fbef 100644 --- a/test/dev/error.test.js +++ b/test/dev/error.test.js @@ -3,7 +3,7 @@ import consola from 'consola' import { loadFixture, getPort, Nuxt } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null // let logSpy @@ -15,7 +15,7 @@ describe('error', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') consola.wrapConsole() }) diff --git a/test/dev/express.test.js b/test/dev/express.test.js index c3c3c3ec3d..a29c9dfeb1 100644 --- a/test/dev/express.test.js +++ b/test/dev/express.test.js @@ -2,7 +2,7 @@ import express from 'express' import { loadFixture, getPort, Nuxt, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt let app diff --git a/test/dev/fallback.test.js b/test/dev/fallback.test.js index f9c5468998..11be78e3f0 100644 --- a/test/dev/fallback.test.js +++ b/test/dev/fallback.test.js @@ -1,7 +1,7 @@ import { getPort, loadFixture, Nuxt, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null @@ -13,7 +13,7 @@ describe('fallback', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('robots.txt handled', async () => { diff --git a/test/dev/filenames-query-part.test.js b/test/dev/filenames-query-part.test.js index b02af36a1a..5faeab66f6 100644 --- a/test/dev/filenames-query-part.test.js +++ b/test/dev/filenames-query-part.test.js @@ -29,7 +29,7 @@ describe('build filenames with query part', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('server manifest files exist', () => { diff --git a/test/dev/full-static-with-preview.test.js b/test/dev/full-static-with-preview.test.js index ab8ee42e3c..4b12c47f49 100644 --- a/test/dev/full-static-with-preview.test.js +++ b/test/dev/full-static-with-preview.test.js @@ -5,7 +5,7 @@ import finalhandler from 'finalhandler' import { Builder, Generator, getPort, loadFixture, Nuxt, waitFor } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const rootDir = resolve(__dirname, '..', 'fixtures/full-static-with-preview') const distDir = resolve(rootDir, '.nuxt-generate') diff --git a/test/dev/full-static.test.js b/test/dev/full-static.test.js index 08a991cbf8..4bbbc431b8 100644 --- a/test/dev/full-static.test.js +++ b/test/dev/full-static.test.js @@ -6,7 +6,7 @@ import glob from 'glob' import { Builder, Generator, getPort, loadFixture, Nuxt, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const rootDir = resolve(__dirname, '..', 'fixtures/full-static') const distDir = resolve(rootDir, '.nuxt-generate') diff --git a/test/dev/modern.client.test.js b/test/dev/modern.client.test.js index 88f531426f..94c0f696d2 100644 --- a/test/dev/modern.client.test.js +++ b/test/dev/modern.client.test.js @@ -1,7 +1,7 @@ import { loadFixture, getPort, Nuxt, rp } from '../utils' let nuxt, port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route describe('modern client mode (SSR)', () => { beforeAll(async () => { @@ -10,7 +10,7 @@ describe('modern client mode (SSR)', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('should contain nomodule legacy resources', async () => { diff --git a/test/dev/modern.server.test.js b/test/dev/modern.server.test.js index 83d01dbc89..3b44ffd39e 100644 --- a/test/dev/modern.server.test.js +++ b/test/dev/modern.server.test.js @@ -2,7 +2,7 @@ import consola from 'consola' import { loadFixture, getPort, Nuxt, rp, wChunk } from '../utils' let nuxt, port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const modernUA = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36' const modernInfo = mode => `Modern bundles are detected. Modern mode (\`${mode}\`) is enabled now.` @@ -13,7 +13,7 @@ describe('modern server mode', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('should detect server modern mode', async () => { diff --git a/test/dev/modern.spa.test.js b/test/dev/modern.spa.test.js index a2ac872367..dfa7bf0854 100644 --- a/test/dev/modern.spa.test.js +++ b/test/dev/modern.spa.test.js @@ -2,7 +2,7 @@ import consola from 'consola' import { loadFixture, getPort, Nuxt, rp } from '../utils' let nuxt, port, options -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const modernUA = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36' const modernInfo = mode => `Modern bundles are detected. Modern mode (\`${mode}\`) is enabled now.` @@ -13,7 +13,7 @@ describe('modern client mode (SPA)', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('should detect client modern mode', async () => { diff --git a/test/dev/module.test.js b/test/dev/module.test.js index fbc6723019..ff2aebf48e 100644 --- a/test/dev/module.test.js +++ b/test/dev/module.test.js @@ -3,7 +3,7 @@ import consola from 'consola' import { loadFixture, getPort, Nuxt, Builder, rp } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route const rootDir = resolve(__dirname, '..', 'fixtures/module') let nuxt = null @@ -16,7 +16,7 @@ describe('module', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('Plugin', async () => { diff --git a/test/dev/nuxt.test.js b/test/dev/nuxt.test.js index ccfc5f438b..29915220b4 100644 --- a/test/dev/nuxt.test.js +++ b/test/dev/nuxt.test.js @@ -39,7 +39,7 @@ describe('nuxt', () => { await nuxt.ready() const port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') const { html } = await nuxt.server.renderRoute('/') expect(html).toContain('

') diff --git a/test/dev/postcss-function.test.js b/test/dev/postcss-function.test.js index d7137ef9d3..4d23a44023 100644 --- a/test/dev/postcss-function.test.js +++ b/test/dev/postcss-function.test.js @@ -1,7 +1,7 @@ import { getPort, loadFixture, Nuxt } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null diff --git a/test/dev/runtime-config.test.js b/test/dev/runtime-config.test.js index 016ef1233e..2c261aee09 100644 --- a/test/dev/runtime-config.test.js +++ b/test/dev/runtime-config.test.js @@ -1,7 +1,7 @@ import { loadFixture, getPort, Nuxt } from '../utils' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null diff --git a/test/dev/server.listen.test.js b/test/dev/server.listen.test.js index 83bf0a02a1..7630893d95 100644 --- a/test/dev/server.listen.test.js +++ b/test/dev/server.listen.test.js @@ -14,14 +14,14 @@ describe('server listen', () => { await nuxt.ready() const port = await getPort() - const listen = () => nuxt.server.listen(port, 'localhost') + const listen = () => nuxt.server.listen(port, '127.0.0.1') // Listen for first time await listen() expect(nuxt.server.listeners[0].port).toBe(port) // Listen for second time - await expect(listen()).rejects.toThrow(`Address \`localhost:${port}\` is already in use.`) + await expect(listen()).rejects.toThrow(`Address \`127.0.0.1:${port}\` is already in use.`) await nuxt.close() }) @@ -31,7 +31,7 @@ describe('server listen', () => { await nuxt.ready() const port = await getPort() - const listen = () => nuxt.server.listen(port, 'localhost') + const listen = () => nuxt.server.listen(port, '127.0.0.1') // Listen for first time await listen() @@ -41,7 +41,7 @@ describe('server listen', () => { await listen() expect(nuxt.server.listeners[1].port).not.toBe(nuxt.server.listeners[0].port) expect(consola.warn).toHaveBeenCalledTimes(1) - expect(consola.warn).toHaveBeenCalledWith(`Address \`localhost:${port}\` is already in use.`) + expect(consola.warn).toHaveBeenCalledWith(`Address \`127.0.0.1:${port}\` is already in use.`) await nuxt.close() }) @@ -59,7 +59,7 @@ describe('server listen', () => { const nuxt = new Nuxt({ ...config, dev: true }) await nuxt.ready() - const listen = () => nuxt.server.listen(0, 'localhost') // Use port 0 to let allow host to randomly assign a free PORT + const listen = () => nuxt.server.listen(0, '127.0.0.1') // Use port 0 to let allow host to randomly assign a free PORT const toString = (x = '') => `${x}` // Nuxt server should not be listening on the DEFAULT_PORT diff --git a/test/dev/spa.test.js b/test/dev/spa.test.js index de90f5b55d..f32adf9bd8 100644 --- a/test/dev/spa.test.js +++ b/test/dev/spa.test.js @@ -4,7 +4,7 @@ import { loadFixture, getPort, Nuxt, wChunk } from '../utils' // Runs tests in specified router mode (either "hash" or "history"). function spaTests ({ isHashMode }) { let nuxt, port - const url = route => `http://localhost:${port}${isHashMode ? '/#' : ''}${route}` + const url = route => `http://127.0.0.1:${port}${isHashMode ? '/#' : ''}${route}` const renderRoute = async (_url) => { const window = await nuxt.server.renderAndGetWindow(url(_url)) @@ -21,7 +21,7 @@ function spaTests ({ isHashMode }) { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('/ (basic spa)', async () => { diff --git a/test/dev/ssr.test.js b/test/dev/ssr.test.js index c91a9866b0..42c7bbd251 100644 --- a/test/dev/ssr.test.js +++ b/test/dev/ssr.test.js @@ -10,7 +10,7 @@ const range = n => [...Array(n).keys()] const FOOBAR_REGEX = /([\s\S]*)<\/Foobar>/ const match = (regex, text) => (regex.exec(text) || [])[1] -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route // const isWindows = /^win/.test(process.platform) @@ -69,7 +69,7 @@ describe('ssr', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('unique responses with data()', async () => { diff --git a/test/dev/trailing-slash-payload.test.js b/test/dev/trailing-slash-payload.test.js index 03b0e4d71f..cfabe1efa7 100644 --- a/test/dev/trailing-slash-payload.test.js +++ b/test/dev/trailing-slash-payload.test.js @@ -6,7 +6,7 @@ import { Builder, Generator, getPort, loadFixture, Nuxt } from '../utils' import renderAndGetWindow from '../../packages/server/src/jsdom' let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let builder let server = null diff --git a/test/dev/trailing-slash.test.js b/test/dev/trailing-slash.test.js index b3371de054..034fcd1982 100644 --- a/test/dev/trailing-slash.test.js +++ b/test/dev/trailing-slash.test.js @@ -10,7 +10,7 @@ function runTest (name, expectations) { nuxt = new Nuxt(options) await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) for (const route in expectations) { diff --git a/test/dev/with-config.test.js b/test/dev/with-config.test.js index cb974264c4..bbb3c392ef 100644 --- a/test/dev/with-config.test.js +++ b/test/dev/with-config.test.js @@ -8,7 +8,7 @@ import { getPort, loadFixture, Nuxt, rp } from '../utils' const glob = pify(Glob) let port -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null @@ -19,7 +19,7 @@ describe('with-config', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('client source map generated', async () => { diff --git a/test/e2e/basic.browser.test.js b/test/e2e/basic.browser.test.js index 578a859c4e..bb869533f5 100644 --- a/test/e2e/basic.browser.test.js +++ b/test/e2e/basic.browser.test.js @@ -3,7 +3,7 @@ import { loadFixture, getPort, Nuxt, waitFor } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page = null @@ -15,7 +15,7 @@ describe('basic browser', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') await browser.start({ // slowMo: 50, diff --git a/test/e2e/basic.navigation.test.js b/test/e2e/basic.navigation.test.js index bc11a07c1e..3e4cf7b97a 100644 --- a/test/e2e/basic.navigation.test.js +++ b/test/e2e/basic.navigation.test.js @@ -3,7 +3,7 @@ import { loadFixture, getPort, Nuxt, waitFor } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page = null @@ -15,7 +15,7 @@ describe('basic browser navigation', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') await browser.start({ // slowMo: 50, diff --git a/test/e2e/basic.vue-config.test.js b/test/e2e/basic.vue-config.test.js index 079cc27448..017ca29647 100644 --- a/test/e2e/basic.vue-config.test.js +++ b/test/e2e/basic.vue-config.test.js @@ -3,7 +3,7 @@ import { getPort, loadFixture, Nuxt } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page = null @@ -14,7 +14,7 @@ const startServer = async (type = 'basic') => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') return nuxt } diff --git a/test/e2e/children.patch.browser.test.js b/test/e2e/children.patch.browser.test.js index 9c3bd69b83..d1b5190c2f 100644 --- a/test/e2e/children.patch.browser.test.js +++ b/test/e2e/children.patch.browser.test.js @@ -3,7 +3,7 @@ import { loadFixture, getPort, Nuxt, waitFor } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page @@ -16,7 +16,7 @@ describe('children patch (browser)', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') }) test('Start browser', async () => { diff --git a/test/e2e/error.test.js b/test/e2e/error.test.js index f34c8efdd3..acc4b9f42a 100644 --- a/test/e2e/error.test.js +++ b/test/e2e/error.test.js @@ -3,7 +3,7 @@ import { loadFixture, getPort, Nuxt } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page = null @@ -15,7 +15,7 @@ describe('basic browser', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') await browser.start({ // slowMo: 50, diff --git a/test/e2e/fetch.browser.test.js b/test/e2e/fetch.browser.test.js index 75863ba7f9..1dd192ebe6 100644 --- a/test/e2e/fetch.browser.test.js +++ b/test/e2e/fetch.browser.test.js @@ -3,7 +3,7 @@ import { loadFixture, getPort, Nuxt } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page = null @@ -15,7 +15,7 @@ describe('basic browser', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') await browser.start({ // slowMo: 50, diff --git a/test/e2e/page-transitions.browser.test.js b/test/e2e/page-transitions.browser.test.js index 783b697a9c..61a2714b67 100644 --- a/test/e2e/page-transitions.browser.test.js +++ b/test/e2e/page-transitions.browser.test.js @@ -3,7 +3,7 @@ import { loadFixture, getPort, Nuxt } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page = null @@ -20,7 +20,7 @@ describe('page transitions (browser)', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') await browser.start({ // slowMo: 50, diff --git a/test/e2e/spa-base.browser.test.js b/test/e2e/spa-base.browser.test.js index 95a914524e..9b405a5c15 100644 --- a/test/e2e/spa-base.browser.test.js +++ b/test/e2e/spa-base.browser.test.js @@ -3,7 +3,7 @@ import { loadFixture, getPort, Nuxt } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page = null @@ -15,7 +15,7 @@ describe('spa router base browser', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') await browser.start({ // slowMo: 50, diff --git a/test/e2e/split-layouts-error.test.js b/test/e2e/split-layouts-error.test.js index 0009a3abe7..c0c03bb307 100644 --- a/test/e2e/split-layouts-error.test.js +++ b/test/e2e/split-layouts-error.test.js @@ -3,7 +3,7 @@ import { loadFixture, getPort, Nuxt } from '../utils' let port const browser = new Browser() -const url = route => 'http://localhost:' + port + route +const url = route => 'http://127.0.0.1:' + port + route let nuxt = null let page = null @@ -15,7 +15,7 @@ describe('split layouts error layout', () => { await nuxt.ready() port = await getPort() - await nuxt.server.listen(port, 'localhost') + await nuxt.server.listen(port, '127.0.0.1') await browser.start() page = await browser.page(url('/')) }) diff --git a/test/fixtures/basic/pages/fetch.vue b/test/fixtures/basic/pages/fetch.vue index 8a07957716..cdf72702f4 100644 --- a/test/fixtures/basic/pages/fetch.vue +++ b/test/fixtures/basic/pages/fetch.vue @@ -13,7 +13,7 @@