From e0782af53eb1d4060992ee9b45f49ddf05900c24 Mon Sep 17 00:00:00 2001 From: Pooya Parsa Date: Thu, 17 Aug 2017 22:54:20 +0430 Subject: [PATCH] enable ModuleConcatenationPlugin for client bundles --- lib/builder/webpack/base.config.js | 5 ----- lib/builder/webpack/client.config.js | 11 ++++++++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/builder/webpack/base.config.js b/lib/builder/webpack/base.config.js index 5463848080..cfb44d1184 100644 --- a/lib/builder/webpack/base.config.js +++ b/lib/builder/webpack/base.config.js @@ -142,11 +142,6 @@ export default function webpackBaseConfig ({ isClient, isServer }) { minimize: true }) ) - - // Scope Hoisting - // config.plugins.push( - // new webpack.optimize.ModuleConcatenationPlugin() - // ) } // Clone deep avoid leaking config between Client and Server diff --git a/lib/builder/webpack/client.config.js b/lib/builder/webpack/client.config.js index cc286eef24..94de0c79d9 100644 --- a/lib/builder/webpack/client.config.js +++ b/lib/builder/webpack/client.config.js @@ -135,6 +135,14 @@ export default function webpackClientConfig () { // Production specific config // -------------------------------------- if (!this.options.dev) { + // Scope Hoisting + config.plugins.push( + new webpack.optimize.ModuleConcatenationPlugin() + ) + + // https://webpack.js.org/plugins/hashed-module-ids-plugin + config.plugins.push(new webpack.HashedModuleIdsPlugin()) + // Minify JS config.plugins.push( new webpack.optimize.UglifyJsPlugin({ @@ -145,9 +153,6 @@ export default function webpackClientConfig () { }) ) - // https://webpack.js.org/plugins/hashed-module-ids-plugin - config.plugins.push(new webpack.HashedModuleIdsPlugin()) - // Webpack Bundle Analyzer if (this.options.build.analyze) { config.plugins.push(