mirror of
https://github.com/nuxt/nuxt.git
synced 2024-11-26 07:32:01 +00:00
fix(nuxt): show error page after fatal abortNavigation
(#21047)
This commit is contained in:
parent
4e6369cefa
commit
e50cabfed1
@ -6,7 +6,7 @@ import { hasProtocol, joinURL, parseURL } from 'ufo'
|
|||||||
|
|
||||||
import { useNuxtApp, useRuntimeConfig } from '../nuxt'
|
import { useNuxtApp, useRuntimeConfig } from '../nuxt'
|
||||||
import type { NuxtError } from './error'
|
import type { NuxtError } from './error'
|
||||||
import { createError } from './error'
|
import { createError, showError } from './error'
|
||||||
import { useState } from './state'
|
import { useState } from './state'
|
||||||
|
|
||||||
import type { PageMeta } from '#app'
|
import type { PageMeta } from '#app'
|
||||||
@ -155,10 +155,16 @@ export const abortNavigation = (err?: string | Partial<NuxtError>) => {
|
|||||||
if (process.dev && !isProcessingMiddleware()) {
|
if (process.dev && !isProcessingMiddleware()) {
|
||||||
throw new Error('abortNavigation() is only usable inside a route middleware handler.')
|
throw new Error('abortNavigation() is only usable inside a route middleware handler.')
|
||||||
}
|
}
|
||||||
if (err) {
|
|
||||||
throw createError(err)
|
if (!err) { return false }
|
||||||
|
|
||||||
|
err = createError(err)
|
||||||
|
|
||||||
|
if (err.fatal) {
|
||||||
|
useNuxtApp().runWithContext(() => showError(err as NuxtError))
|
||||||
}
|
}
|
||||||
return false
|
|
||||||
|
throw err
|
||||||
}
|
}
|
||||||
|
|
||||||
export const setPageLayout = (layout: string) => {
|
export const setPageLayout = (layout: string) => {
|
||||||
|
@ -710,6 +710,14 @@ describe('middlewares', () => {
|
|||||||
expect(res.status).toEqual(401)
|
expect(res.status).toEqual(401)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it('should allow aborting navigation fatally on client-side', async () => {
|
||||||
|
const html = await $fetch('/middleware-abort')
|
||||||
|
expect(html).not.toContain('This is the error page')
|
||||||
|
const page = await createPage('/middleware-abort')
|
||||||
|
await page.waitForLoadState('networkidle')
|
||||||
|
expect(await page.innerHTML('body')).toContain('This is the error page')
|
||||||
|
})
|
||||||
|
|
||||||
it('should inject auth', async () => {
|
it('should inject auth', async () => {
|
||||||
const html = await $fetch('/auth')
|
const html = await $fetch('/auth')
|
||||||
|
|
||||||
|
18
test/fixtures/basic/pages/middleware-abort.vue
vendored
Normal file
18
test/fixtures/basic/pages/middleware-abort.vue
vendored
Normal file
@ -0,0 +1,18 @@
|
|||||||
|
<script setup lang="ts">
|
||||||
|
definePageMeta({
|
||||||
|
middleware: () => {
|
||||||
|
if (process.server || useNuxtApp().isHydrating) { return }
|
||||||
|
return abortNavigation({
|
||||||
|
fatal: true
|
||||||
|
})
|
||||||
|
}
|
||||||
|
})
|
||||||
|
const router = useRouter()
|
||||||
|
onNuxtReady(() => router.push({ path: '/middleware-abort', force: true }))
|
||||||
|
</script>
|
||||||
|
|
||||||
|
<template>
|
||||||
|
<div>
|
||||||
|
<!-- -->
|
||||||
|
</div>
|
||||||
|
</template>
|
Loading…
Reference in New Issue
Block a user