Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-22 13:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(nuxt): remove key from useId type signature (#25614)

Browse Source
This commit is contained in:
Daniel Roe 2024-02-04 22:11:53 +00:00 committed by GitHub
parent 3e5560ed42
commit e8d1219886
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/nuxt/src/app/composables/id.ts
View File

@ -7,6 +7,7 @@ const ATTR_KEY = 'data-n-ids'
/** /**
* Generate an SSR-friendly unique identifier that can be passed to accessibility attributes. * Generate an SSR-friendly unique identifier that can be passed to accessibility attributes.
*/ */
export function useId (): string
export function useId (key?: string): string { export function useId (key?: string): string {
if (typeof key !== 'string') { if (typeof key !== 'string') {
throw new TypeError('[nuxt] [useId] key must be a string.') throw new TypeError('[nuxt] [useId] key must be a string.')

5
test/fixtures/basic-types/types.ts vendored
View File

@ -362,6 +362,11 @@ describe('composables', () => {
expectTypeOf(useFetch('/test', { default: () => 500 }).data).toEqualTypeOf<Ref<unknown>>() expectTypeOf(useFetch('/test', { default: () => 500 }).data).toEqualTypeOf<Ref<unknown>>()
}) })
it('prevents passing string to `useId`', () => {
// @ts-expect-error providing a key is not allowed
useId('test')
})
it('enforces readonly cookies', () => { it('enforces readonly cookies', () => {
// @ts-expect-error readonly cookie // @ts-expect-error readonly cookie
useCookie('test', { readonly: true }).value = 'thing' useCookie('test', { readonly: true }).value = 'thing'