Zengtudor
/
Nuxt
mirror of https://github.com/nuxt/nuxt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

perf(nuxt): abort vue render when plugins throw error (#27304)

This commit is contained in:
Daniel Roe 2024-05-22 15:40:19 +01:00 committed by GitHub
parent 8a759bc6fe
commit eb0bebc46d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/nuxt/src/app/components/nuxt-root.vue
View File

@ -1,7 +1,8 @@
<template> <template>
<Suspense @resolve="onResolve"> <Suspense @resolve="onResolve">
<div v-if="abortRender" />
<ErrorComponent <ErrorComponent
v-if="error" v-else-if="error"
:error="error" :error="error"
/> />
<IslandRenderer <IslandRenderer
@ -53,6 +54,8 @@ if (import.meta.dev && results && results.some(i => i && 'then' in i)) {
// error handling // error handling
const error = useError() const error = useError()
// render an empty <div> when plugins have thrown an error but we're not yet rendering the error page
const abortRender = import.meta.server && error.value && !nuxtApp.ssrContext.error
onErrorCaptured((err, target, info) => { onErrorCaptured((err, target, info) => {
nuxtApp.hooks.callHook('vue:error', err, target, info).catch(hookError => console.error('[nuxt] Error in `vue:error` hook', hookError)) nuxtApp.hooks.callHook('vue:error', err, target, info).catch(hookError => console.error('[nuxt] Error in `vue:error` hook', hookError))
if (import.meta.server || (isNuxtError(err) && (err.fatal || err.unhandled))) { if (import.meta.server || (isNuxtError(err) && (err.fatal || err.unhandled))) {