Zengtudor/Nuxt
1
0
Fork 0
mirror of https://github.com/nuxt/nuxt.git synced 2024-11-22 21:55:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(nuxt): handle external navigation to api routes (#19829)

Browse Source
This commit is contained in:
Daniel Roe 2023-03-20 17:15:01 +00:00 committed by GitHub
parent cebfcb3dad
commit ebd7dcd4ba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nuxt/src/app/composables/router.ts
View File

@ -90,7 +90,7 @@ export const navigateTo = (to: RouteLocationRaw | undefined | null, options?: Na
} }
const toPath = typeof to === 'string' ? to : ((to as RouteLocationPathRaw).path || '/') const toPath = typeof to === 'string' ? to : ((to as RouteLocationPathRaw).path || '/')
const isExternal = hasProtocol(toPath, { acceptRelative: true }) const isExternal = options?.external || hasProtocol(toPath, { acceptRelative: true })
if (isExternal && !options?.external) { if (isExternal && !options?.external) {
throw new Error('Navigating to external URL is not allowed by default. Use `navigateTo (url, { external: true })`.') throw new Error('Navigating to external URL is not allowed by default. Use `navigateTo (url, { external: true })`.')
} }

6
test/basic.test.ts
View File

@ -528,6 +528,12 @@ describe('navigate external', () => {
expect(headers.get('location')).toEqual('https://example.com/') expect(headers.get('location')).toEqual('https://example.com/')
}) })
it('should redirect to api endpoint', async () => {
const { headers } = await fetch('/navigate-to-api', { redirect: 'manual' })
expect(headers.get('location')).toEqual('/api/test')
})
}) })
describe('middlewares', () => { describe('middlewares', () => {

2
test/bundle.test.ts
View File

@ -26,7 +26,7 @@ describe.skipIf(isWindows)('minimal nuxt application', () => {
it('default client bundle size', async () => { it('default client bundle size', async () => {
stats.client = await analyzeSizes('**/*.js', publicDir) stats.client = await analyzeSizes('**/*.js', publicDir)
expect(stats.client.totalBytes).toBeLessThan(106500) expect(stats.client.totalBytes).toBeLessThan(106600)
expect(stats.client.files.map(f => f.replace(/\..*\.js/, '.js'))).toMatchInlineSnapshot(` expect(stats.client.files.map(f => f.replace(/\..*\.js/, '.js'))).toMatchInlineSnapshot(`
[ [
"_nuxt/_plugin-vue_export-helper.js", "_nuxt/_plugin-vue_export-helper.js",

7
test/fixtures/basic/pages/navigate-to-api.vue vendored Normal file
View File

@ -0,0 +1,7 @@
<template>
<div>You should not see me</div>
</template>
<script setup>
await navigateTo('/api/test', { external: true })
</script>