From feaebff82352f2b5c00e80ae71bd36234a9e6a78 Mon Sep 17 00:00:00 2001
From: Daniel Roe <daniel@roe.dev>
Date: Tue, 4 Apr 2023 14:39:10 +0100
Subject: [PATCH] ci: enable autofix for pr linting (#20085)

---
 .github/workflows/autofix-docs.yml | 28 +++++++++++++++++++++++++
 .github/workflows/autofix.yml      | 33 ++++++++++++++++++++++++++++++
 .github/workflows/ci.yml           |  5 ++---
 .github/workflows/docs.yml         | 11 +++++-----
 .github/workflows/introspect.yml   |  2 +-
 package.json                       |  1 +
 6 files changed, 70 insertions(+), 10 deletions(-)
 create mode 100644 .github/workflows/autofix-docs.yml
 create mode 100644 .github/workflows/autofix.yml

diff --git a/.github/workflows/autofix-docs.yml b/.github/workflows/autofix-docs.yml
new file mode 100644
index 0000000000..0d57d2d011
--- /dev/null
+++ b/.github/workflows/autofix-docs.yml
@@ -0,0 +1,28 @@
+name: autofix.ci  # needed to securely identify the workflow
+
+on:
+  pull_request:
+    paths:
+      - "docs/**"
+      - ".github/workflows/docs.yml"
+
+permissions:
+  contents: read
+
+jobs:
+  docs:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+      - run: corepack enable
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+          cache: "pnpm"
+
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Lint (docs)
+        run: pnpm lint:docs:fix
diff --git a/.github/workflows/autofix.yml b/.github/workflows/autofix.yml
new file mode 100644
index 0000000000..464c285e10
--- /dev/null
+++ b/.github/workflows/autofix.yml
@@ -0,0 +1,33 @@
+name: autofix.ci  # needed to securely identify the workflow
+
+on:
+  pull_request:
+    paths-ignore:
+      - "docs/**"
+
+permissions:
+  contents: read
+
+jobs:
+  code:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+      - run: corepack enable
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+          cache: "pnpm"
+
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Build (stub)
+        run: pnpm build:stub
+
+      - name: Lint (code)
+        run: pnpm lint:fix
+
+      - name: Test (unit)
+        run: pnpm test:unit -u
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0dd3c6fcd6..bc7bb96e26 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -88,6 +88,8 @@ jobs:
         run: pnpm test:types
 
   lint:
+    # autofix workflow will be triggered instead for PRs
+    if: github.event_name == 'push'
     runs-on: ubuntu-latest
     timeout-minutes: 10
 
@@ -169,9 +171,6 @@ jobs:
 
       - name: Test (unit)
         run: pnpm test:unit
-        env:
-          TEST_ENV: ${{ matrix.env }}
-          TEST_BUILDER: ${{ matrix.builder }}
 
       - name: Test (fixtures)
         run: pnpm test:fixtures
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 69d21567cb..a2d96f9a06 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -5,14 +5,13 @@ on:
     paths:
       - "docs/**"
       - ".github/workflows/docs.yml"
+    # autofix workflow will be triggered instead for PRs
     branches:
       - main
-  pull_request:
-    paths:
-      - "docs/**"
-      - ".github/workflows/docs.yml"
-    branches:
-      - main
+
+# Remove default permissions of GITHUB_TOKEN for security
+# https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
+permissions: {}
 
 jobs:
   lint-docs:
diff --git a/.github/workflows/introspect.yml b/.github/workflows/introspect.yml
index 4e295577e6..99b843dc71 100644
--- a/.github/workflows/introspect.yml
+++ b/.github/workflows/introspect.yml
@@ -1,4 +1,4 @@
-name: Docs
+name: CI
 
 on:
   push:
diff --git a/package.json b/package.json
index f241733f91..f9e8d6da7b 100644
--- a/package.json
+++ b/package.json
@@ -12,6 +12,7 @@
     "example": "./scripts/example.sh dev",
     "example:build": "./scripts/example.sh build",
     "lint": "eslint --ext .vue,.ts,.js,.mjs .",
+    "lint:fix": "eslint --ext .vue,.ts,.js,.mjs . --fix",
     "lint:docs": "markdownlint ./docs && case-police 'docs/**/*.md'",
     "lint:docs:fix": "markdownlint ./docs --fix && case-police 'docs/**/*.md' --fix",
     "nuxi": "JITI_ESM_RESOLVE=1 nuxi",