From 08fb60a6750afe43c2af421632746015856f9d5c Mon Sep 17 00:00:00 2001
From: Jacob Dufault <jacobdufault@gmail.com>
Date: Wed, 19 Jul 2017 00:17:38 -0700
Subject: [PATCH] Show call tree expand button if function has base or derived
 callers.

---
 src/query_utils.cc | 37 +++++++++++++++++++++++++++++++++++--
 src/query_utils.h  |  1 +
 2 files changed, 36 insertions(+), 2 deletions(-)

diff --git a/src/query_utils.cc b/src/query_utils.cc
index 0423f03f..d75fde0d 100644
--- a/src/query_utils.cc
+++ b/src/query_utils.cc
@@ -283,6 +283,39 @@ optional<QueryLocation> GetBaseDefinitionOrDeclarationSpelling(QueryDatabase* db
   return def;
 }
 
+bool HasCallersOnSelfOrBaseOrDerived(QueryDatabase* db, QueryFunc& root) {
+  // Check self.
+  if (!root.callers.empty())
+    return true;
+
+  // Check for base calls.
+  optional<QueryFuncId> func_id = root.def.base;
+  while (func_id) {
+    optional<QueryFunc>& func = db->funcs[func_id->id];
+    if (!func)
+      break;
+    if (!func->callers.empty())
+      return true;
+    func_id = func->def.base;
+  }
+
+  // Check for derived calls.
+  std::queue<QueryFuncId> queue;
+  PushRange(&queue, root.derived);
+  while (!queue.empty()) {
+    optional<QueryFunc>& func = db->funcs[queue.front().id];
+    queue.pop();
+    if (!func)
+      continue;
+
+    if (!func->derived.empty())
+      return true;
+    PushRange(&queue, func->derived);
+  }
+
+  return false;
+}
+
 std::vector<QueryFuncRef> GetCallersForAllBaseFunctions(QueryDatabase* db, QueryFunc& root) {
   std::vector<QueryFuncRef> callers;
 
@@ -654,7 +687,7 @@ NonElidedVector<Out_CqueryCallTree::CallEntry> BuildInitialCallTree(QueryDatabas
   entry.name = root_func->def.short_name;
   entry.usr = root_func->def.usr;
   entry.location = *def_loc;
-  entry.hasCallers = !root_func->callers.empty();
+  entry.hasCallers = HasCallersOnSelfOrBaseOrDerived(db, *root_func);
   NonElidedVector<Out_CqueryCallTree::CallEntry> result;
   result.push_back(entry);
   return result;
@@ -709,7 +742,7 @@ NonElidedVector<Out_CqueryCallTree::CallEntry> BuildExpandCallTree(QueryDatabase
       call_entry.name = prefix + call_func->def.short_name + " (" + format_location(*call_location) + ")";
       call_entry.usr = call_func->def.usr;
       call_entry.location = *call_location;
-      call_entry.hasCallers = !call_func->callers.empty();
+      call_entry.hasCallers = HasCallersOnSelfOrBaseOrDerived(db, *call_func);
       result.push_back(call_entry);
     }
     else {
diff --git a/src/query_utils.h b/src/query_utils.h
index 124bcffb..4feade09 100644
--- a/src/query_utils.h
+++ b/src/query_utils.h
@@ -21,6 +21,7 @@ std::vector<QueryLocation> ToQueryLocation(QueryDatabase* db, const std::vector<
 std::vector<QueryLocation> GetUsesOfSymbol(QueryDatabase* db, const SymbolIdx& symbol);
 std::vector<QueryLocation> GetDeclarationsOfSymbolForGotoDefinition(QueryDatabase* db, const SymbolIdx& symbol);
 optional<QueryLocation> GetBaseDefinitionOrDeclarationSpelling(QueryDatabase* db, QueryFunc& func);
+bool HasCallersOnSelfOrBaseOrDerived(QueryDatabase* db, QueryFunc& root);
 std::vector<QueryFuncRef> GetCallersForAllBaseFunctions(QueryDatabase* db, QueryFunc& root);
 std::vector<QueryFuncRef> GetCallersForAllDerivedFunctions(QueryDatabase* db, QueryFunc& root);
 optional<lsPosition> GetLsPosition(WorkingFile* working_file, const Position& position);