[hover] Better heuristics to insert function name right before the paren pair enclosing parameters (#178)

This commit is contained in:
Fangrui Song 2017-12-23 09:29:13 -08:00 committed by GitHub
parent fb491e6c6d
commit 156d4891c3

View File

@ -1203,17 +1203,24 @@ void OnIndexDeclaration(CXClientData client_data, const CXIdxDeclInfo* decl) {
ns->QualifiedName(decl->semanticContainer, func->def.short_name); ns->QualifiedName(decl->semanticContainer, func->def.short_name);
std::string type_desc = decl_cursor.get_type_description(); std::string type_desc = decl_cursor.get_type_description();
{ {
size_t offset = 0; size_t balance = 0, offset;
if (type_desc.back() == ')') {
size_t balance = 0;
for (offset = type_desc.size(); offset;) { for (offset = type_desc.size(); offset;) {
offset--; offset--;
if (type_desc[offset] == ')') if (type_desc[offset] == ')')
balance++; balance++;
else if (type_desc[offset] == '(' && --balance == 0) // Balanced paren pair that may appear before the paren enclosing
// function parameters, see clang/lib/AST/TypePrinter.cpp
else if (type_desc[offset] == '(' && --balance == 0 &&
!((offset >= 5 &&
!type_desc.compare(offset - 5, 5, "throw")) ||
(offset >= 6 &&
!type_desc.compare(offset - 6, 6, "typeof")) ||
(offset >= 8 &&
!type_desc.compare(offset - 8, 8, "decltype")) ||
(offset >= 13 &&
!type_desc.compare(offset - 13, 13, "__attribute__"))))
break; break;
} }
}
if (offset > 0) { if (offset > 0) {
type_desc.insert(offset, qualified_name); type_desc.insert(offset, qualified_name);
func->def.detailed_name = type_desc; func->def.detailed_name = type_desc;