In OnIndexDeclaration, get_type_description() may return the name of a typedef and there is no (, causing insert failing

This commit is contained in:
Fangrui Song 2017-12-12 00:02:27 -08:00 committed by Jacob Dufault
parent 33c3d99925
commit 17f23bf3bf

View File

@ -1161,8 +1161,13 @@ void OnIndexDeclaration(CXClientData client_data, const CXIdxDeclInfo* decl) {
ns->QualifiedName(decl->semanticContainer, func->def.short_name); ns->QualifiedName(decl->semanticContainer, func->def.short_name);
std::string type_desc = decl_cursor.get_type_description(); std::string type_desc = decl_cursor.get_type_description();
size_t offset = type_desc.find('('); size_t offset = type_desc.find('(');
type_desc.insert(offset, qualified_name); if (offset != std::string::npos) {
func->def.detailed_name = type_desc; type_desc.insert(offset, qualified_name);
func->def.detailed_name = type_desc;
} else {
// type_desc is probably the name of a typedef.
func->def.detailed_name = type_desc + " " + qualified_name;
}
// Add function usage information. We only want to do it once per // Add function usage information. We only want to do it once per
// definition/declaration. Do it on definition since there should only // definition/declaration. Do it on definition since there should only