From 2ebaadd696ea1bea829f2b9ae3299c0a5257efaf Mon Sep 17 00:00:00 2001 From: Jacob Dufault Date: Sun, 16 Apr 2017 01:55:14 -0700 Subject: [PATCH] Small nits --- src/code_completion.cc | 6 +++--- src/language_server_api.h | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/code_completion.cc b/src/code_completion.cc index 9e870625..59aa6cdd 100644 --- a/src/code_completion.cc +++ b/src/code_completion.cc @@ -98,7 +98,7 @@ std::string BuildLabelString(CXCompletionString completion_string) { std::string label; int num_chunks = clang_getNumCompletionChunks(completion_string); - for (unsigned i = 0; i < num_chunks; ++i) { + for (int i = 0; i < num_chunks; ++i) { CXCompletionChunkKind kind = clang_getCompletionChunkKind(completion_string, i); if (kind == CXCompletionChunk_TypedText) { label += clang::ToString(clang_getCompletionChunkText(completion_string, i)); @@ -113,7 +113,7 @@ std::string BuildDetailString(CXCompletionString completion_string) { std::string detail; int num_chunks = clang_getNumCompletionChunks(completion_string); - for (unsigned i = 0; i < num_chunks; ++i) { + for (int i = 0; i < num_chunks; ++i) { CXCompletionChunkKind kind = clang_getCompletionChunkKind(completion_string, i); switch (kind) { @@ -272,7 +272,7 @@ NonElidedVector CompletionManager::CodeComplete(const lsTextDo ls_result.reserve(cx_results->NumResults); timer.Reset(); - for (int i = 0; i < cx_results->NumResults; ++i) { + for (unsigned i = 0; i < cx_results->NumResults; ++i) { CXCompletionResult& result = cx_results->Results[i]; //unsigned int is_incomplete; diff --git a/src/language_server_api.h b/src/language_server_api.h index cd3c8aec..09d3a3c5 100644 --- a/src/language_server_api.h +++ b/src/language_server_api.h @@ -491,6 +491,7 @@ MAKE_REFLECT_STRUCT(lsTextDocumentEdit, textDocument, edits); struct lsWorkspaceEdit { // Holds changes to existing resources. // changes ? : { [uri:string]: TextEdit[]; }; + //std::unordered_map> changes; // An array of `TextDocumentEdit`s to express changes to specific a specific // version of a text document. Whether a client supports versioned document @@ -1112,7 +1113,7 @@ struct Ipc_TextDocumentDidSave : public IpcMessage { struct Params { // The document that was saved. lsTextDocumentIdentifier textDocument; - + // Optional the content when saved. Depends on the includeText value // when the save notifcation was requested. // std::string text;