remove some todos

This commit is contained in:
Jacob Dufault 2017-02-19 23:55:29 -08:00
parent 0dabbb3093
commit 43072452e5
3 changed files with 3 additions and 11 deletions

View File

@ -161,7 +161,6 @@ struct VarDef {
std::optional<TypeId> declaring_type; std::optional<TypeId> declaring_type;
// Usages. // Usages.
//std::vector<clang::SourceLocation> initializations; // TODO: See if we can support this.
std::vector<clang::SourceLocation> all_uses; std::vector<clang::SourceLocation> all_uses;
VarDef(VarId id, const std::string& usr) : id(id), usr(usr) { VarDef(VarId id, const std::string& usr) : id(id), usr(usr) {
@ -1814,7 +1813,6 @@ int main(int argc, char** argv) {
*/ */
for (std::string path : GetFilesInFolder("tests")) { for (std::string path : GetFilesInFolder("tests")) {
// TODO: Fix all existing tests.
//if (path != "tests/declaration_vs_definition/method.cc") continue; //if (path != "tests/declaration_vs_definition/method.cc") continue;
//if (path == "tests/usage/type_usage_declare_extern.cc") continue; //if (path == "tests/usage/type_usage_declare_extern.cc") continue;
//if (path != "tests/constructors/destructor.cc") continue; //if (path != "tests/constructors/destructor.cc") continue;
@ -1859,4 +1857,4 @@ int main(int argc, char** argv) {
return 0; return 0;
} }
// TODO: ctor/dtor, copy ctor, class inheritance, method inheritance // TODO: ctor/dtor, copy ctor

View File

@ -4,11 +4,8 @@ class Foo {
/* /*
// NOTE: Lack of declaring_type in functions and funcs in Foo is okay, because // NOTE: Lack of declaring_type in functions and funcs in Foo is okay, because
// those are processed when we find the definition for Foo::foo. // those are processed when we find the definition for Foo::foo. Pure
// TODO: Verify the strategy above works well with pure virtual interfaces and // virtuals are treated specially and get added to the type immediately.
// the like (ie, we need to provide a good outline view). We could just
// add the info in the declaration if the func is pure virtual - see
// clang_CXXMethod_isPureVirtual
OUTPUT: OUTPUT:
{ {

View File

@ -4,9 +4,6 @@ class Foo {
Foo* Foo::member = nullptr; Foo* Foo::member = nullptr;
/* /*
// TODO: Store both declaration and definition. It is very convenient to
// quickly change between them.
OUTPUT: OUTPUT:
{ {
"types": [{ "types": [{