Zengtudor/ccls
1
0
Fork 0
mirror of https://github.com/MaskRay/ccls.git synced 2024-11-22 15:45:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[indexer] Treat explicit destructor call as not is_implicit (#159)

Browse Source 
Also fixed an unused warning.
This commit is contained in:
Fangrui Song 2017-12-18 13:48:32 -08:00 committed by GitHub
parent 0cf54f3557
commit 5600989a42
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/indexer.cc
View File

@ -1443,6 +1443,10 @@ void OnIndexReference(CXClientData client_data, const CXIdxEntityRefInfo* ref) {
// or implicit), but libclang only supports implicit for objective-c.
bool is_implicit =
CanBeCalledImplicitly(ref->referencedEntity->kind) &&
// For explicit destructor call, ref->cursor may be "~" while called->def.short_name is "~A"
// "~A" is not a substring of ref->cursor, but we should take this case as not `is_implicit`.
called->def.short_name.size() && called->def.short_name[0] != '~' &&
!CursorSpellingContainsString(ref->cursor, param->tu->cx_tu,
called->def.short_name);

4
src/platform_posix.cc
View File

@ -342,9 +342,7 @@ out_error:
bool IsSymLink(const std::string& path) {
struct stat buf;
int result;
result = lstat(path.c_str(), &buf);
return S_ISLNK(buf.st_mode);
return lstat(path.c_str(), &buf) == 0 && S_ISLNK(buf.st_mode);
}
std::vector<std::string> GetPlatformClangArguments() {