Zengtudor/ccls
1
0
Fork 0
mirror of https://github.com/MaskRay/ccls.git synced 2025-02-22 00:19:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Change short_names/detailed_names from const std::string& to std::string_view

Browse Source
This commit is contained in:
Fangrui Song 2018-01-31 19:53:50 -08:00 committed by GitHub
parent c33aa113db
commit 8108de0cfa
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/messages/workspace_symbol.cc
View File

@ -124,8 +124,8 @@ gap_penalty(k+1, j) + score[j] : k < j))
The first dimension can be suppressed since we do not need a matching scheme, The first dimension can be suppressed since we do not need a matching scheme,
which reduces the space complexity from O(N*M) to O(M) which reduces the space complexity from O(N*M) to O(M)
*/ */
int FuzzyEvaluate(const std::string& pattern, int FuzzyEvaluate(std::string_view pattern,
const std::string& str, std::string_view str,
std::vector<int>& score, std::vector<int>& score,
std::vector<int>& dp) { std::vector<int>& dp) {
bool pfirst = true, // aligning the first character of pattern bool pfirst = true, // aligning the first character of pattern
@ -204,7 +204,7 @@ struct WorkspaceSymbolHandler : BaseMessageHandler<Ipc_WorkspaceSymbol> {
for (int i = 0; i < db->detailed_names.size(); ++i) { for (int i = 0; i < db->detailed_names.size(); ++i) {
if (db->detailed_names[i].find(query) != std::string::npos) { if (db->detailed_names[i].find(query) != std::string::npos) {
// Do not show the same entry twice. // Do not show the same entry twice.
if (!inserted_results.insert(db->detailed_names[i]).second) if (!inserted_results.insert(std::string(db->detailed_names[i])).second)
continue; continue;
if (InsertSymbolIntoResult(db, working_files, db->symbols[i], if (InsertSymbolIntoResult(db, working_files, db->symbols[i],
@ -227,7 +227,7 @@ struct WorkspaceSymbolHandler : BaseMessageHandler<Ipc_WorkspaceSymbol> {
for (int i = 0; i < db->short_names.size(); ++i) { for (int i = 0; i < db->short_names.size(); ++i) {
if (SubsequenceMatch(query_without_space, db->short_names[i])) { if (SubsequenceMatch(query_without_space, db->short_names[i])) {
// Do not show the same entry twice. // Do not show the same entry twice.
if (!inserted_results.insert(db->detailed_names[i]).second) if (!inserted_results.insert(std::string(db->detailed_names[i])).second)
continue; continue;
if (InsertSymbolIntoResult(db, working_files, db->symbols[i], if (InsertSymbolIntoResult(db, working_files, db->symbols[i],

4
src/query.cc
View File

@ -943,8 +943,8 @@ void QueryDatabase::ImportOrUpdate(
void QueryDatabase::UpdateDetailedNames(size_t* qualified_name_index, void QueryDatabase::UpdateDetailedNames(size_t* qualified_name_index,
SymbolKind kind, SymbolKind kind,
size_t symbol_index, size_t symbol_index,
const std::string& short_name, std::string_view short_name,
const std::string& detailed_name) { std::string_view detailed_name) {
if (*qualified_name_index == -1) { if (*qualified_name_index == -1) {
short_names.push_back(short_name); short_names.push_back(short_name);
detailed_names.push_back(detailed_name); detailed_names.push_back(detailed_name);

8
src/query.h
View File

@ -363,8 +363,8 @@ MAKE_HASHABLE(NormalizedPath, t.path);
struct QueryDatabase { struct QueryDatabase {
// Indicies between lookup vectors are related to symbols, ie, index 5 in // Indicies between lookup vectors are related to symbols, ie, index 5 in
// |detailed_names| matches index 5 in |symbols|. // |detailed_names| matches index 5 in |symbols|.
std::vector<std::string> detailed_names; std::vector<std::string_view> detailed_names;
std::vector<std::string> short_names; std::vector<std::string_view> short_names;
std::vector<SymbolIdx> symbols; std::vector<SymbolIdx> symbols;
// Raw data storage. Accessible via SymbolIdx instances. // Raw data storage. Accessible via SymbolIdx instances.
@ -390,8 +390,8 @@ struct QueryDatabase {
void UpdateDetailedNames(size_t* qualified_name_index, void UpdateDetailedNames(size_t* qualified_name_index,
SymbolKind kind, SymbolKind kind,
size_t symbol_index, size_t symbol_index,
const std::string& short_name, std::string_view short_name,
const std::string& detailed_name); std::string_view detailed_name);
// Query the indexing structure to look up symbol id for given Usr. // Query the indexing structure to look up symbol id for given Usr.
optional<QueryFileId> GetQueryFileIdFromPath(const std::string& path); optional<QueryFileId> GetQueryFileIdFromPath(const std::string& path);