Zengtudor/ccls
1
0
Fork 0
mirror of https://github.com/MaskRay/ccls.git synced 2025-01-19 12:05:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Only allow one active index request per file when actively editing.

Browse Source
This commit is contained in:
Jacob Dufault 2017-05-08 22:09:57 -07:00
parent ad0a03b0da
commit 8ed20567a1
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/command_line.cc
View File

@ -1517,14 +1517,23 @@ bool QueryDbMainLoop(
auto msg = static_cast<Ipc_TextDocumentDidSave*>(message.get()); auto msg = static_cast<Ipc_TextDocumentDidSave*>(message.get());
std::string path = msg->params.textDocument.uri.GetPath(); std::string path = msg->params.textDocument.uri.GetPath();
// Send an index update request. // Send out an index request, and copy the current buffer state so we
// TODO: Make sure we don't mess up header files when guessing. // can update the cached index contents when the index is done.
queue_do_index->Enqueue(Index_DoIndex(Index_DoIndex::Type::Parse, project->FindCompilationEntryForFile(path))); //
// We also do not index if there is already an index request.
// Copy current buffer content so it can be applied when index request is done. //
// TODO: Cancel outgoing index request. Might be tricky to make
// efficient since we have to cancel.
// - we could have an |atomic<int> active_cancellations| variable
// that all of the indexers check before accepting an index. if
// zero we don't slow down fast-path. if non-zero we acquire
// mutex and check to see if we should skip the current request.
// if so, ignore that index response.
WorkingFile* working_file = working_files->GetFileByFilename(path); WorkingFile* working_file = working_files->GetFileByFilename(path);
if (working_file) if (working_file && !working_file->pending_new_index_content) {
working_file->pending_new_index_content = working_file->buffer_content; working_file->pending_new_index_content = working_file->buffer_content;
queue_do_index->Enqueue(Index_DoIndex(Index_DoIndex::Type::Parse, project->FindCompilationEntryForFile(path)));
}
break; break;
} }