Zengtudor/ccls
1
0
Fork 0
mirror of https://github.com/MaskRay/ccls.git synced 2024-11-22 15:45:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix tests hanging in MultiQueueWaiter destructor.

Browse Source 
std::condition_variable_any destructor is only safe to invoke if all
threads have been notified.

Reference:
https://en.cppreference.com/w/cpp/thread/condition_variable_any/%7Econdition_variable_any

Signed-off-by: Ernest Borowski <e.borowski.git@protonmail.com>
This commit is contained in:
Ernest Borowski 2020-07-27 00:48:45 +02:00
parent 4cf16a7e5a
commit ba34c2a75c
No known key found for this signature in database
GPG Key ID: 4ACA3E667585A409
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/threaded_queue.hh
View File

@ -46,6 +46,9 @@ private:
struct MultiQueueWaiter { struct MultiQueueWaiter {
std::condition_variable_any cv; std::condition_variable_any cv;
~MultiQueueWaiter() {
cv.notify_all();
}
static bool hasState(std::initializer_list<BaseThreadQueue *> queues) { static bool hasState(std::initializer_list<BaseThreadQueue *> queues) {
for (BaseThreadQueue *queue : queues) { for (BaseThreadQueue *queue : queues) {