Merge $cquery/*Hierarchy{Initial,Expand}

src/command_line.cc

@@ -342,12 +342,9 @@ void LaunchStdinLoop(Config* config,
         case IpcId::WorkspaceSymbol:
         case IpcId::CqueryFileInfo:
         case IpcId::CqueryFreshenIndex:
-        case IpcId::CqueryCallHierarchyInitial:
+        case IpcId::CqueryCallHierarchy:
-        case IpcId::CqueryCallHierarchyExpand:
+        case IpcId::CqueryInheritanceHierarchy:
-        case IpcId::CqueryInheritanceHierarchyInitial:
+        case IpcId::CqueryMemberHierarchy:
-        case IpcId::CqueryInheritanceHierarchyExpand:
-        case IpcId::CqueryMemberHierarchyInitial:
-        case IpcId::CqueryMemberHierarchyExpand:
         case IpcId::CqueryVars:
         case IpcId::CqueryCallers:
         case IpcId::CqueryBase:

src/ipc.cc

@@ -70,18 +70,12 @@ const char* IpcIdToString(IpcId id) {
       return "$cquery/fileInfo";
     case IpcId::CqueryFreshenIndex:
       return "$cquery/freshenIndex";
-    case IpcId::CqueryCallHierarchyInitial:
+    case IpcId::CqueryCallHierarchy:
-      return "$cquery/callHierarchyInitial";
+      return "$cquery/callHierarchy";
-    case IpcId::CqueryCallHierarchyExpand:
+    case IpcId::CqueryInheritanceHierarchy:
-      return "$cquery/callHierarchyExpand";
+      return "$cquery/inheritanceHierarchy";
-    case IpcId::CqueryInheritanceHierarchyInitial:
+    case IpcId::CqueryMemberHierarchy:
-      return "$cquery/inheritanceHierarchyInitial";
+      return "$cquery/memberHierarchy";
-    case IpcId::CqueryInheritanceHierarchyExpand:
-      return "$cquery/inheritanceHierarchyExpand";
-    case IpcId::CqueryMemberHierarchyInitial:
-      return "$cquery/memberHierarchyInitial";
-    case IpcId::CqueryMemberHierarchyExpand:
-      return "$cquery/memberHierarchyExpand";
     case IpcId::CqueryVars:
       return "$cquery/vars";
     case IpcId::CqueryCallers:

src/ipc.h

@@ -48,12 +48,9 @@ enum class IpcId : int {
   CqueryFileInfo,
   CqueryFreshenIndex,
   // Messages used in tree views.
-  CqueryCallHierarchyInitial,
+  CqueryCallHierarchy,
-  CqueryCallHierarchyExpand,
+  CqueryInheritanceHierarchy,
-  CqueryInheritanceHierarchyInitial,
+  CqueryMemberHierarchy,
-  CqueryInheritanceHierarchyExpand,
-  CqueryMemberHierarchyInitial,
-  CqueryMemberHierarchyExpand,
   // These are like DocumentReferences but show different types of data.
   CqueryVars,     // Show all variables of a type.
   CqueryCallers,  // Show all callers of a function.

src/messages/cquery_call_hierarchy.cc

@@ -12,12 +12,17 @@ bool operator&(CallType lhs, CallType rhs) {
   return uint8_t(lhs) & uint8_t(rhs);
 }
 
-struct Ipc_CqueryCallHierarchyInitial
+struct Ipc_CqueryCallHierarchy
-    : public RequestMessage<Ipc_CqueryCallHierarchyInitial> {
+    : public RequestMessage<Ipc_CqueryCallHierarchy> {
-  const static IpcId kIpcId = IpcId::CqueryCallHierarchyInitial;
+  const static IpcId kIpcId = IpcId::CqueryCallHierarchy;
   struct Params {
+    // If id is specified, expand a node; otherwise textDocument+position should
+    // be specified for building the root and |levels| of nodes below.
     lsTextDocumentIdentifier textDocument;
     lsPosition position;
+
+    Maybe<QueryFuncId> id;
+
     // true: callee tree (functions called by this function); false: caller tree
     // (where this function is called)
     bool callee = false;
@@ -29,36 +34,16 @@ struct Ipc_CqueryCallHierarchyInitial
   };
   Params params;
 };
-MAKE_REFLECT_STRUCT(Ipc_CqueryCallHierarchyInitial::Params,
+MAKE_REFLECT_STRUCT(Ipc_CqueryCallHierarchy::Params,
                     textDocument,
                     position,
-                    callee,
-                    callType,
-                    detailedName,
-                    levels);
-MAKE_REFLECT_STRUCT(Ipc_CqueryCallHierarchyInitial, id, params);
-REGISTER_IPC_MESSAGE(Ipc_CqueryCallHierarchyInitial);
-
-struct Ipc_CqueryCallHierarchyExpand
-    : public RequestMessage<Ipc_CqueryCallHierarchyExpand> {
-  const static IpcId kIpcId = IpcId::CqueryCallHierarchyExpand;
-  struct Params {
-    Maybe<QueryFuncId> id;
-    bool callee = false;
-    CallType callType = CallType::Direct;
-    bool detailedName = false;
-    int levels = 1;
-  };
-  Params params;
-};
-MAKE_REFLECT_STRUCT(Ipc_CqueryCallHierarchyExpand::Params,
                     id,
                     callee,
                     callType,
                     detailedName,
                     levels);
-MAKE_REFLECT_STRUCT(Ipc_CqueryCallHierarchyExpand, id, params);
+MAKE_REFLECT_STRUCT(Ipc_CqueryCallHierarchy, id, params);
-REGISTER_IPC_MESSAGE(Ipc_CqueryCallHierarchyExpand);
+REGISTER_IPC_MESSAGE(Ipc_CqueryCallHierarchy);
 
 struct Out_CqueryCallHierarchy : public lsOutMessage<Out_CqueryCallHierarchy> {
   struct Entry {
@@ -167,8 +152,8 @@ bool Expand(MessageHandler* m,
   return true;
 }
 
-struct CqueryCallHierarchyInitialHandler
+struct CqueryCallHierarchyHandler
-    : BaseMessageHandler<Ipc_CqueryCallHierarchyInitial> {
+    : BaseMessageHandler<Ipc_CqueryCallHierarchy> {
   optional<Out_CqueryCallHierarchy::Entry> BuildInitial(QueryFuncId root_id,
                                                         bool callee,
                                                         CallType call_type,
@@ -185,18 +170,26 @@ struct CqueryCallHierarchyInitialHandler
     return entry;
   }
 
-  void Run(Ipc_CqueryCallHierarchyInitial* request) override {
+  void Run(Ipc_CqueryCallHierarchy* request) override {
-    QueryFile* file;
     const auto& params = request->params;
-    if (!FindFileOrFail(db, project, request->id,
-                        params.textDocument.uri.GetPath(), &file))
-      return;
-
-    WorkingFile* working_file =
-        working_files->GetFileByFilename(file->def->path);
     Out_CqueryCallHierarchy out;
     out.id = request->id;
 
+    if (params.id) {
+      Out_CqueryCallHierarchy::Entry entry;
+      entry.id = *params.id;
+      entry.callType = CallType::Direct;
+      if (entry.id.id < db->funcs.size())
+        Expand(this, &entry, params.callee, params.callType,
+               params.detailedName, params.levels);
+      out.result = std::move(entry);
+    } else {
+      QueryFile* file;
+      if (!FindFileOrFail(db, project, request->id,
+                          params.textDocument.uri.GetPath(), &file))
+        return;
+      WorkingFile* working_file =
+          working_files->GetFileByFilename(file->def->path);
       for (SymbolRef sym :
           FindSymbolsAtLocation(working_file, file, params.position)) {
         if (sym.kind == SymbolKind::Func) {
@@ -206,30 +199,11 @@ struct CqueryCallHierarchyInitialHandler
           break;
         }
       }
+    }
 
-    QueueManager::WriteStdout(IpcId::CqueryCallHierarchyInitial, out);
+    QueueManager::WriteStdout(IpcId::CqueryCallHierarchy, out);
   }
 };
-REGISTER_MESSAGE_HANDLER(CqueryCallHierarchyInitialHandler);
+REGISTER_MESSAGE_HANDLER(CqueryCallHierarchyHandler);
 
-struct CqueryCallHierarchyExpandHandler
-    : BaseMessageHandler<Ipc_CqueryCallHierarchyExpand> {
-  void Run(Ipc_CqueryCallHierarchyExpand* request) override {
-    const auto& params = request->params;
-    Out_CqueryCallHierarchy out;
-    out.id = request->id;
-    if (params.id) {
-      Out_CqueryCallHierarchy::Entry entry;
-      entry.id = *params.id;
-      entry.callType = CallType::Direct;
-      if (entry.id.id < db->funcs.size())
-        Expand(this, &entry, params.callee, params.callType,
-               params.detailedName, params.levels);
-      out.result = std::move(entry);
-    }
-
-    QueueManager::WriteStdout(IpcId::CqueryCallHierarchyExpand, out);
-  }
-};
-REGISTER_MESSAGE_HANDLER(CqueryCallHierarchyExpandHandler);
 }  // namespace

src/messages/cquery_inheritance_hierarchy.cc

@@ -3,12 +3,18 @@
 #include "queue_manager.h"
 
 namespace {
-struct Ipc_CqueryInheritanceHierarchyInitial
+struct Ipc_CqueryInheritanceHierarchy
-    : public RequestMessage<Ipc_CqueryInheritanceHierarchyInitial> {
+    : public RequestMessage<Ipc_CqueryInheritanceHierarchy> {
-  const static IpcId kIpcId = IpcId::CqueryInheritanceHierarchyInitial;
+  const static IpcId kIpcId = IpcId::CqueryInheritanceHierarchy;
   struct Params {
+    // If id+kind are specified, expand a node; otherwise textDocument+position should
+    // be specified for building the root and |levels| of nodes below.
     lsTextDocumentIdentifier textDocument;
     lsPosition position;
+
+    Maybe<Id<void>> id;
+    SymbolKind kind = SymbolKind::Invalid;
+
     // true: derived classes/functions; false: base classes/functions
     bool derived = false;
     bool detailedName = false;
@@ -17,35 +23,16 @@ struct Ipc_CqueryInheritanceHierarchyInitial
   Params params;
 };
 
-MAKE_REFLECT_STRUCT(Ipc_CqueryInheritanceHierarchyInitial::Params,
+MAKE_REFLECT_STRUCT(Ipc_CqueryInheritanceHierarchy::Params,
                     textDocument,
                     position,
-                    derived,
-                    detailedName,
-                    levels);
-MAKE_REFLECT_STRUCT(Ipc_CqueryInheritanceHierarchyInitial, id, params);
-REGISTER_IPC_MESSAGE(Ipc_CqueryInheritanceHierarchyInitial);
-
-struct Ipc_CqueryInheritanceHierarchyExpand
-    : public RequestMessage<Ipc_CqueryInheritanceHierarchyExpand> {
-  const static IpcId kIpcId = IpcId::CqueryInheritanceHierarchyExpand;
-  struct Params {
-    Maybe<Id<void>> id;
-    SymbolKind kind = SymbolKind::Invalid;
-    bool derived = false;
-    bool detailedName = false;
-    int levels = 1;
-  };
-  Params params;
-};
-MAKE_REFLECT_STRUCT(Ipc_CqueryInheritanceHierarchyExpand::Params,
                     id,
                     kind,
                     derived,
                     detailedName,
                     levels);
-MAKE_REFLECT_STRUCT(Ipc_CqueryInheritanceHierarchyExpand, id, params);
+MAKE_REFLECT_STRUCT(Ipc_CqueryInheritanceHierarchy, id, params);
-REGISTER_IPC_MESSAGE(Ipc_CqueryInheritanceHierarchyExpand);
+REGISTER_IPC_MESSAGE(Ipc_CqueryInheritanceHierarchy);
 
 struct Out_CqueryInheritanceHierarchy
     : public lsOutMessage<Out_CqueryInheritanceHierarchy> {
@@ -140,8 +127,8 @@ bool Expand(MessageHandler* m,
                         m->db->types[entry->id.id]);
 }
 
-struct CqueryInheritanceHierarchyInitialHandler
+struct CqueryInheritanceHierarchyHandler
-    : BaseMessageHandler<Ipc_CqueryInheritanceHierarchyInitial> {
+    : BaseMessageHandler<Ipc_CqueryInheritanceHierarchy> {
   optional<Out_CqueryInheritanceHierarchy::Entry>
   BuildInitial(SymbolRef sym, bool derived, bool detailed_name, int levels) {
     Out_CqueryInheritanceHierarchy::Entry entry;
@@ -151,38 +138,11 @@ struct CqueryInheritanceHierarchyInitialHandler
     return entry;
   }
 
-  void Run(Ipc_CqueryInheritanceHierarchyInitial* request) override {
+  void Run(Ipc_CqueryInheritanceHierarchy* request) override {
-    const auto& params = request->params;
-    QueryFile* file;
-    if (!FindFileOrFail(db, project, request->id,
-                        params.textDocument.uri.GetPath(), &file))
-      return;
-
-    WorkingFile* working_file =
-        working_files->GetFileByFilename(file->def->path);
-    Out_CqueryInheritanceHierarchy out;
-    out.id = request->id;
-
-    for (SymbolRef sym :
-         FindSymbolsAtLocation(working_file, file, request->params.position)) {
-      if (sym.kind == SymbolKind::Func || sym.kind == SymbolKind::Type) {
-        out.result = BuildInitial(sym, params.derived, params.detailedName,
-                                  params.levels);
-        break;
-      }
-    }
-
-    QueueManager::WriteStdout(IpcId::CqueryInheritanceHierarchyInitial, out);
-  }
-};
-REGISTER_MESSAGE_HANDLER(CqueryInheritanceHierarchyInitialHandler);
-
-struct CqueryInheritanceHierarchyExpandHandler
-  : BaseMessageHandler<Ipc_CqueryInheritanceHierarchyExpand> {
-  void Run(Ipc_CqueryInheritanceHierarchyExpand* request) override {
     const auto& params = request->params;
     Out_CqueryInheritanceHierarchy out;
     out.id = request->id;
+
     if (params.id) {
       Out_CqueryInheritanceHierarchy::Entry entry;
       entry.id = *params.id;
@@ -193,10 +153,27 @@ struct CqueryInheritanceHierarchyExpandHandler
           Expand(this, &entry, params.derived, params.detailedName,
                  params.levels))
         out.result = std::move(entry);
+    } else {
+      QueryFile* file;
+      if (!FindFileOrFail(db, project, request->id,
+                          params.textDocument.uri.GetPath(), &file))
+        return;
+      WorkingFile* working_file =
+          working_files->GetFileByFilename(file->def->path);
+
+      for (SymbolRef sym :
+          FindSymbolsAtLocation(working_file, file, request->params.position)) {
+        if (sym.kind == SymbolKind::Func || sym.kind == SymbolKind::Type) {
+          out.result = BuildInitial(sym, params.derived, params.detailedName,
+                                    params.levels);
+          break;
+        }
+      }
     }
 
-    QueueManager::WriteStdout(IpcId::CqueryInheritanceHierarchyExpand, out);
+    QueueManager::WriteStdout(IpcId::CqueryInheritanceHierarchy, out);
   }
 };
-REGISTER_MESSAGE_HANDLER(CqueryInheritanceHierarchyExpandHandler);
+REGISTER_MESSAGE_HANDLER(CqueryInheritanceHierarchyHandler);
+
 }  // namespace

src/messages/cquery_member_hierarchy.cc

@@ -3,39 +3,31 @@
 #include "queue_manager.h"
 
 namespace {
-struct Ipc_CqueryMemberHierarchyInitial
+struct Ipc_CqueryMemberHierarchy
-    : public RequestMessage<Ipc_CqueryMemberHierarchyInitial> {
+    : public RequestMessage<Ipc_CqueryMemberHierarchy> {
-  const static IpcId kIpcId = IpcId::CqueryMemberHierarchyInitial;
+  const static IpcId kIpcId = IpcId::CqueryMemberHierarchy;
   struct Params {
+    // If id is specified, expand a node; otherwise textDocument+position should
+    // be specified for building the root and |levels| of nodes below.
     lsTextDocumentIdentifier textDocument;
     lsPosition position;
+
+    Maybe<QueryTypeId> id;
+
     bool detailedName = false;
     int levels = 1;
   };
   Params params;
 };
 
-MAKE_REFLECT_STRUCT(Ipc_CqueryMemberHierarchyInitial::Params,
+MAKE_REFLECT_STRUCT(Ipc_CqueryMemberHierarchy::Params,
                     textDocument,
                     position,
+                    id,
                     detailedName,
                     levels);
-MAKE_REFLECT_STRUCT(Ipc_CqueryMemberHierarchyInitial, id, params);
+MAKE_REFLECT_STRUCT(Ipc_CqueryMemberHierarchy, id, params);
-REGISTER_IPC_MESSAGE(Ipc_CqueryMemberHierarchyInitial);
+REGISTER_IPC_MESSAGE(Ipc_CqueryMemberHierarchy);
-
-struct Ipc_CqueryMemberHierarchyExpand
-    : public RequestMessage<Ipc_CqueryMemberHierarchyExpand> {
-  const static IpcId kIpcId = IpcId::CqueryMemberHierarchyExpand;
-  struct Params {
-    Maybe<QueryTypeId> id;
-    bool detailedName = false;
-    int levels = 1;
-  };
-  Params params;
-};
-MAKE_REFLECT_STRUCT(Ipc_CqueryMemberHierarchyExpand::Params, id, detailedName, levels);
-MAKE_REFLECT_STRUCT(Ipc_CqueryMemberHierarchyExpand, id, params);
-REGISTER_IPC_MESSAGE(Ipc_CqueryMemberHierarchyExpand);
 
 struct Out_CqueryMemberHierarchy
     : public lsOutMessage<Out_CqueryMemberHierarchy> {
@@ -166,8 +158,8 @@ bool Expand(MessageHandler* m,
   return true;
 }
 
-struct CqueryMemberHierarchyInitialHandler
+struct CqueryMemberHierarchyHandler
-    : BaseMessageHandler<Ipc_CqueryMemberHierarchyInitial> {
+    : BaseMessageHandler<Ipc_CqueryMemberHierarchy> {
   optional<Out_CqueryMemberHierarchy::Entry> BuildInitial(QueryFuncId root_id,
                                                           bool detailed_name,
                                                           int levels) {
@@ -210,18 +202,25 @@ struct CqueryMemberHierarchyInitialHandler
     return entry;
   }
 
-  void Run(Ipc_CqueryMemberHierarchyInitial* request) override {
+  void Run(Ipc_CqueryMemberHierarchy* request) override {
-    QueryFile* file;
     const auto& params = request->params;
-    if (!FindFileOrFail(db, project, request->id,
-                        params.textDocument.uri.GetPath(), &file))
-      return;
-
-    WorkingFile* working_file =
-        working_files->GetFileByFilename(file->def->path);
     Out_CqueryMemberHierarchy out;
     out.id = request->id;
 
+    if (params.id) {
+      Out_CqueryMemberHierarchy::Entry entry;
+      entry.id = *request->params.id;
+      // entry.name is empty as it is known by the client.
+      if (entry.id.id < db->types.size() &&
+          Expand(this, &entry, params.detailedName, params.levels))
+        out.result = std::move(entry);
+    } else {
+      QueryFile* file;
+      if (!FindFileOrFail(db, project, request->id,
+                          params.textDocument.uri.GetPath(), &file))
+        return;
+      WorkingFile* working_file =
+        working_files->GetFileByFilename(file->def->path);
       for (SymbolRef sym :
              FindSymbolsAtLocation(working_file, file, params.position)) {
         switch (sym.kind) {
@@ -236,8 +235,8 @@ struct CqueryMemberHierarchyInitialHandler
         case SymbolKind::Var: {
           const QueryVar::Def* def = db->GetVar(sym).AnyDef();
           if (def && def->type)
-          out.result = BuildInitial(QueryTypeId(*def->type),
+            out.result = BuildInitial(QueryTypeId(*def->type), params.detailedName,
-                                    params.detailedName, params.levels);
+                                      params.levels);
           break;
         }
         default:
@@ -245,29 +244,11 @@ struct CqueryMemberHierarchyInitialHandler
         }
         break;
       }
+    }
 
-    QueueManager::WriteStdout(IpcId::CqueryMemberHierarchyInitial, out);
+    QueueManager::WriteStdout(IpcId::CqueryMemberHierarchy, out);
   }
 };
-REGISTER_MESSAGE_HANDLER(CqueryMemberHierarchyInitialHandler);
+REGISTER_MESSAGE_HANDLER(CqueryMemberHierarchyHandler);
 
-struct CqueryMemberHierarchyExpandHandler
-    : BaseMessageHandler<Ipc_CqueryMemberHierarchyExpand> {
-  void Run(Ipc_CqueryMemberHierarchyExpand* request) override {
-    const auto& params = request->params;
-    Out_CqueryMemberHierarchy out;
-    out.id = request->id;
-    if (params.id) {
-      Out_CqueryMemberHierarchy::Entry entry;
-      entry.id = *request->params.id;
-      // entry.name is empty as it is known by the client.
-      if (entry.id.id < db->types.size() &&
-          Expand(this, &entry, params.detailedName, params.levels))
-        out.result = std::move(entry);
-    }
-
-    QueueManager::WriteStdout(IpcId::CqueryMemberHierarchyExpand, out);
-  }
-};
-REGISTER_MESSAGE_HANDLER(CqueryMemberHierarchyExpandHandler);
 }  // namespace