From 05418cc854c8f05462617c2f2a2ecd546c9eb0c9 Mon Sep 17 00:00:00 2001
From: Fangrui Song <i@maskray.me>
Date: Fri, 16 Nov 2018 01:05:27 -0800
Subject: [PATCH] Add LSP.md

---
 LSP.md      | 25 +++++++++++++++++++++++++
 _Sidebar.md |  1 +
 2 files changed, 26 insertions(+)
 create mode 100644 LSP.md

diff --git a/LSP.md b/LSP.md
new file mode 100644
index 0000000..5d400da
--- /dev/null
+++ b/LSP.md
@@ -0,0 +1,25 @@
+MaskRay's random complaints about Language Server Protocol
+
+### Completion
+
+* VSCode sorts `sortText` case insensitively.
+* VSCode only allows length-one strings in `CompletionRegistrationOptions.triggerCharacters` https://github.com/Microsoft/language-server-protocol/issues/138 (closed) Server developers have to work around that. `CompletionTriggerKind::TriggerCharacter` should extend as well.
+* The order of `textEdit` `additionTextEdits` is not specified.
+
+### Formatting
+
+* `firstTriggerCharacter` and `moreTriggerCharacter` should be unified
+
+### Miscellaneous
+
+* `interface Position` uses UTF-16 counting for `character`. https://github.com/Microsoft/language-server-protocol/issues/376
+* `interface Command` (`workspace/executeCommand`) is VSCode centric.
+* `textDocument/implementation` isn't clear. `textDocument/definition` isn't clear when it comes to the difference of declaration/definition.
+* `namespace DocumentHighlightKind` is not a bitmask. `Read` and `Write` cannot coexist.
+* Why can't we get more `namespace SymbolKind` constants sooner? https://github.com/Microsoft/language-server-protocol/issues/344
+
+## Stuff that needs attention
+
+`textDocument/calls` https://github.com/Microsoft/vscode-languageserver-node/pull/420/files
+
+`$ccls/call`
diff --git a/_Sidebar.md b/_Sidebar.md
index 824491d..a5615fe 100644
--- a/_Sidebar.md
+++ b/_Sidebar.md
@@ -11,3 +11,4 @@
   - [[Visual Studio Code]]
 * [[Debugging]]
 * [[Client feature table]]
+* [[LSP]]