Resolve review comments

This commit is contained in:
Kirill Bobyrev 2021-08-04 09:17:42 +02:00
parent 0b3318b09f
commit e04c78ae44
No known key found for this signature in database
GPG Key ID: 2307C055C8384FA0

View File

@ -93,6 +93,9 @@ jobs:
name: Create release name: Create release
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: [schedule_environment, workflow_dispatch_environment] needs: [schedule_environment, workflow_dispatch_environment]
# Use always() and manually check results here since GitHub Actions do not
# support conditionally skipping jobs and there is no way to "exit with
# success" from a job.
if: always() && (needs.schedule_environment.result == 'success' || needs.workflow_dispatch_environment.result == 'success') if: always() && (needs.schedule_environment.result == 'success' || needs.workflow_dispatch_environment.result == 'success')
steps: steps:
- name: Fetch environment variables - name: Fetch environment variables
@ -235,11 +238,14 @@ jobs:
with: with:
name: name:
release release
- name: Get release info - name: Put release info into env
run: | run: |
cat env/commit.env >> $GITHUB_ENV cat env/commit.env >> $GITHUB_ENV
cat release/release.env >> $GITHUB_ENV cat release/release.env >> $GITHUB_ENV
shell: bash shell: bash
# Use environment variables set above to create a directory. This needs
# to be a separate step because they are not in the context yet when
# being set.
- name: Set build directory - name: Set build directory
run: | run: |
echo "CLANGD_DIR=clangd_${{ env.TAG_NAME }}" >> $GITHUB_ENV echo "CLANGD_DIR=clangd_${{ env.TAG_NAME }}" >> $GITHUB_ENV