Fix MacOS CI builds (#2354)

- Use container: ubuntu:20.04 instead of container: ubuntu:18.04.
- Add `exp` to `lib_compat.h` to solve the GLIBC 2.29 dependency issue.

Fixes https://github.com/clangd/clangd/issues/2244

.github/ISSUE_TEMPLATE/bug_report.md

@@ -17,6 +17,9 @@ If you can, provide a minimal chunk of code that shows the problem (either inlin
 Please attach the clangd stderr log if you can. (Usually available from the editor)
 If possible, run with `--log=verbose` - note that the logs will include the contents of open files!
 If this is a crash, try to put `llvm-symbolizer` on your PATH per the troubleshooting instructions.
+(If you're using Windows, place the associated PDB file (debug symbols) in the same directory as
+clangd.exe and rerun again. For official releases, download symbols from the
+[release page](https://github.com/clangd/clangd/releases).)
 
 **System information**
 

.github/workflows/autobuild.yaml

@@ -5,6 +5,8 @@
 # Because the build takes more than an hour, our GITHUB_TOKEN credentials may
 # expire. A token `secrets.RELEASE_TOKEN` must exist with public_repo scope.
 name: Build release binaries
+env:
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
 on:
   # Run weekly on sunday at 21:37 UTC (arbitrary)
   schedule:
@@ -68,7 +70,7 @@ jobs:
       run: >
         echo "RELEASE_DESCRIPTION=Unstable snapshot of clangd on ${{ env.RELEASE_DATE }}." >> commit.env
     - name: Upload result
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: env
         path: commit.env
@@ -85,7 +87,7 @@ jobs:
         echo "RELEASE_NAME=${{ github.event.inputs.release_name }}" >> commit.env
         echo "RELEASE_DESCRIPTION=${{ github.event.inputs.description }}" >> commit.env
     - name: Upload result
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: env
         path: commit.env
@@ -99,10 +101,12 @@ jobs:
     if: always() && (needs.schedule_environment.result == 'success' || needs.workflow_dispatch_environment.result == 'success')
     steps:
     - name: Fetch environment variables
-      uses: actions/download-artifact@v1
+      uses: actions/download-artifact@v4
       with:
         name:
           env
+        path:
+          env
     - name: Set environment variables
       run: |
         cat env/commit.env >> $GITHUB_ENV
@@ -126,7 +130,7 @@ jobs:
         echo "TAG_NAME=${{ env.TAG_NAME }}" >> release.env
         echo "RELEASE_ID=${{ steps.create_release.outputs.id }}" >> release.env
     - name: Upload result
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: release
         path: release.env
@@ -152,11 +156,13 @@ jobs:
             "-DCMAKE_CXX_COMPILER=cl"
             "-DLLVM_ENABLE_ZLIB=OFF"
             "-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded"
+            "-DLLVM_ENABLE_PDB=ON"
+            "-DLLVM_PARALLEL_LINK_JOBS=1"
           grpc_cmake: >-
             "-DgRPC_MSVC_STATIC_RUNTIME=ON"
           binary_extension: ".exe"
         - name: mac
-          os: macos-latest
+          os: macos-13
           preinstall: brew install ninja zlib p7zip
           cflags: -O3 -gline-tables-only -DNDEBUG
           cmake: >-
@@ -164,13 +170,13 @@ jobs:
             "-DCMAKE_CXX_COMPILER=clang++"
             "-DLLVM_ENABLE_ZLIB=FORCE_ON"
             "-DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"
-            "-DCMAKE_OSX_DEPLOYMENT_TARGET=10.9"
+            "-DCMAKE_OSX_DEPLOYMENT_TARGET=10.13"
           # BoringSSL doesn't support universal binaries when building with ASM.
           grpc_cmake: >-
             "-DOPENSSL_NO_ASM=ON"
         - name: linux
           os: ubuntu-latest
-          container: ubuntu:18.04
+          container: ubuntu:20.04
           preinstall: >-
             apt-get update &&
             apt-get install -y ninja-build libz-dev libc-ares-dev wget clang-9
@@ -179,7 +185,7 @@ jobs:
             wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | apt-key add - &&
             apt-add-repository 'deb https://apt.kitware.com/ubuntu/ bionic main' &&
             apt-get update &&
-            apt-get install -y git cmake
+            apt-get install -y git cmake python3.8 python3.8-dev
           cflags: -O3 -gline-tables-only -DNDEBUG -include $GITHUB_WORKSPACE/.github/workflows/lib_compat.h
           cmake: >-
             "-DCMAKE_C_COMPILER=clang-9"
@@ -239,15 +245,19 @@ jobs:
 
         ninja -C grpc-build install
     - name: Fetch target commit
-      uses: actions/download-artifact@v1
+      uses: actions/download-artifact@v4
       with:
         name:
           env
+        path:
+          env
     - name: Fetch release info
-      uses: actions/download-artifact@v1
+      uses: actions/download-artifact@v4
       with:
         name:
           release
+        path:
+          release
     - name: Put release info into env
       run: |
         cat env/commit.env >> $GITHUB_ENV
@@ -301,6 +311,12 @@ jobs:
         ${{ env.CLANGD_DIR }}/LICENSE.TXT
         ${{ env.CLANGD_DIR }}/bin/clangd${{ matrix.config.binary_extension }}
         ${{ env.CLANGD_DIR }}/lib/clang
+    - name: Archive clangd PDB symbols
+      if: matrix.config.name == 'windows'
+      run: >
+        7z a clangd-pdb.7z -t7z -m0=LZMA2
+        ${{ env.CLANGD_DIR }}/LICENSE.TXT
+        ${{ env.CLANGD_DIR }}/bin/clangd.pdb
     - name: Archive indexing-tools
       run: >
         7z a indexing-tools.zip
@@ -318,6 +334,16 @@ jobs:
         asset_name: clangd-${{ matrix.config.name }}-${{ env.TAG_NAME }}.zip
         asset_path: clangd.zip
         asset_content_type: application/zip
+    - name: Upload clangd PDB asset
+      if: matrix.config.name == 'windows'
+      uses: actions/upload-release-asset@v1.0.1
+      env:
+        GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}
+      with:
+        upload_url: ${{ env.UPLOAD_URL }}
+        asset_name: clangd-${{ matrix.config.name }}-${{ env.TAG_NAME }}-debug-symbols.7z
+        asset_path: clangd-pdb.7z
+        asset_content_type: application/zip
     - name: Upload indexing-tools asset
       uses: actions/upload-release-asset@v1.0.1
       env:
@@ -337,10 +363,12 @@ jobs:
     if: always() && needs.build.result == 'success'
     steps:
     - name: Fetch release info
-      uses: actions/download-artifact@v1
+      uses: actions/download-artifact@v4
       with:
         name:
           release
+        path:
+          release
     - name: Update the env variables
       run: >
         cat release/release.env >> $GITHUB_ENV

.github/workflows/lib_compat.h

@@ -16,5 +16,6 @@ FORCE_SYMBOL_VERSION(expf, GLIBC_2.2.5);
 FORCE_SYMBOL_VERSION(log, GLIBC_2.2.5);
 FORCE_SYMBOL_VERSION(log2, GLIBC_2.2.5);
 FORCE_SYMBOL_VERSION(pow, GLIBC_2.2.5);
+FORCE_SYMBOL_VERSION(exp, GLIBC_2.2.5);
 
 #undef FORCE_SYMBOL_VERSION