Automatically publish release packages to winget (#2445)

As of https://github.com/actions/runner-images/issues/12934, the Mac runners use CMake 4.0, which drops compatibility with CMake < 3.5, but the gRPC library version we use is marked as having CMake 3.1 as its minimum version.

Work around this by using `-DCMAKE_POLICY_VERSION_MINIMUM=3.5`.

.github/ISSUE_TEMPLATE/bug_report.md

@@ -17,6 +17,9 @@ If you can, provide a minimal chunk of code that shows the problem (either inlin
 Please attach the clangd stderr log if you can. (Usually available from the editor)
 If possible, run with `--log=verbose` - note that the logs will include the contents of open files!
 If this is a crash, try to put `llvm-symbolizer` on your PATH per the troubleshooting instructions.
+(If you're using Windows, place the associated PDB file (debug symbols) in the same directory as
+clangd.exe and rerun again. For official releases, download symbols from the
+[release page](https://github.com/clangd/clangd/releases).)
 
 **System information**
 

.github/workflows/autobuild.yaml

@@ -70,7 +70,7 @@ jobs:
       run: >
         echo "RELEASE_DESCRIPTION=Unstable snapshot of clangd on ${{ env.RELEASE_DATE }}." >> commit.env
     - name: Upload result
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: env
         path: commit.env
@@ -87,7 +87,7 @@ jobs:
         echo "RELEASE_NAME=${{ github.event.inputs.release_name }}" >> commit.env
         echo "RELEASE_DESCRIPTION=${{ github.event.inputs.description }}" >> commit.env
     - name: Upload result
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: env
         path: commit.env
@@ -101,10 +101,12 @@ jobs:
     if: always() && (needs.schedule_environment.result == 'success' || needs.workflow_dispatch_environment.result == 'success')
     steps:
     - name: Fetch environment variables
-      uses: actions/download-artifact@v1
+      uses: actions/download-artifact@v4
       with:
         name:
           env
+        path:
+          env
     - name: Set environment variables
       run: |
         cat env/commit.env >> $GITHUB_ENV
@@ -128,7 +130,7 @@ jobs:
         echo "TAG_NAME=${{ env.TAG_NAME }}" >> release.env
         echo "RELEASE_ID=${{ steps.create_release.outputs.id }}" >> release.env
     - name: Upload result
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: release
         path: release.env
@@ -145,20 +147,22 @@ jobs:
       matrix:
         config:
         - name: windows
-          os: windows-2019
+          os: windows-2022
           preinstall: choco install ninja nasm
-          vcvars: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat
+          vcvars: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat
           cflags: /O2 /DNDEBUG
           cmake: >-
             "-DCMAKE_C_COMPILER=cl"
             "-DCMAKE_CXX_COMPILER=cl"
             "-DLLVM_ENABLE_ZLIB=OFF"
             "-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded"
+            "-DLLVM_ENABLE_PDB=ON"
+            "-DLLVM_PARALLEL_LINK_JOBS=1"
           grpc_cmake: >-
             "-DgRPC_MSVC_STATIC_RUNTIME=ON"
           binary_extension: ".exe"
         - name: mac
-          os: macos-12
+          os: macos-13
           preinstall: brew install ninja zlib p7zip
           cflags: -O3 -gline-tables-only -DNDEBUG
           cmake: >-
@@ -166,16 +170,17 @@ jobs:
             "-DCMAKE_CXX_COMPILER=clang++"
             "-DLLVM_ENABLE_ZLIB=FORCE_ON"
             "-DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"
-            "-DCMAKE_OSX_DEPLOYMENT_TARGET=10.9"
+            "-DCMAKE_OSX_DEPLOYMENT_TARGET=10.13"
+            "-DCMAKE_POLICY_VERSION_MINIMUM=3.5"
           # BoringSSL doesn't support universal binaries when building with ASM.
           grpc_cmake: >-
             "-DOPENSSL_NO_ASM=ON"
         - name: linux
           os: ubuntu-latest
-          container: ubuntu:18.04
+          container: ubuntu:20.04
           preinstall: >-
             apt-get update &&
-            apt-get install -y ninja-build libz-dev libc-ares-dev wget clang-9
+            apt-get install -y ninja-build libz-dev libc-ares-dev wget clang-10
             software-properties-common p7zip-full curl &&
             add-apt-repository ppa:git-core/ppa &&
             wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | apt-key add - &&
@@ -184,8 +189,8 @@ jobs:
             apt-get install -y git cmake python3.8 python3.8-dev
           cflags: -O3 -gline-tables-only -DNDEBUG -include $GITHUB_WORKSPACE/.github/workflows/lib_compat.h
           cmake: >-
-            "-DCMAKE_C_COMPILER=clang-9"
+            "-DCMAKE_C_COMPILER=clang-10"
-            "-DCMAKE_CXX_COMPILER=clang++-9"
+            "-DCMAKE_CXX_COMPILER=clang++-10"
             "-DCMAKE_EXE_LINKER_FLAGS_RELEASE=-static-libgcc -Wl,--compress-debug-sections=zlib"
             "-DLLVM_STATIC_LINK_CXX_STDLIB=ON"
             "-DLLVM_ENABLE_ZLIB=FORCE_ON"
@@ -241,15 +246,19 @@ jobs:
 
         ninja -C grpc-build install
     - name: Fetch target commit
-      uses: actions/download-artifact@v1
+      uses: actions/download-artifact@v4
       with:
         name:
           env
+        path:
+          env
     - name: Fetch release info
-      uses: actions/download-artifact@v1
+      uses: actions/download-artifact@v4
       with:
         name:
           release
+        path:
+          release
     - name: Put release info into env
       run: |
         cat env/commit.env >> $GITHUB_ENV
@@ -303,6 +312,12 @@ jobs:
         ${{ env.CLANGD_DIR }}/LICENSE.TXT
         ${{ env.CLANGD_DIR }}/bin/clangd${{ matrix.config.binary_extension }}
         ${{ env.CLANGD_DIR }}/lib/clang
+    - name: Archive clangd PDB symbols
+      if: matrix.config.name == 'windows'
+      run: >
+        7z a clangd-pdb.7z -t7z -m0=LZMA2
+        ${{ env.CLANGD_DIR }}/LICENSE.TXT
+        ${{ env.CLANGD_DIR }}/bin/clangd.pdb
     - name: Archive indexing-tools
       run: >
         7z a indexing-tools.zip
@@ -320,6 +335,16 @@ jobs:
         asset_name: clangd-${{ matrix.config.name }}-${{ env.TAG_NAME }}.zip
         asset_path: clangd.zip
         asset_content_type: application/zip
+    - name: Upload clangd PDB asset
+      if: matrix.config.name == 'windows'
+      uses: actions/upload-release-asset@v1.0.1
+      env:
+        GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}
+      with:
+        upload_url: ${{ env.UPLOAD_URL }}
+        asset_name: clangd-debug-symbols-${{ matrix.config.name }}-${{ env.TAG_NAME }}.7z
+        asset_path: clangd-pdb.7z
+        asset_content_type: application/zip
     - name: Upload indexing-tools asset
       uses: actions/upload-release-asset@v1.0.1
       env:
@@ -339,10 +364,12 @@ jobs:
     if: always() && needs.build.result == 'success'
     steps:
     - name: Fetch release info
-      uses: actions/download-artifact@v1
+      uses: actions/download-artifact@v4
       with:
         name:
           release
+        path:
+          release
     - name: Update the env variables
       run: >
         cat release/release.env >> $GITHUB_ENV

.github/workflows/lib_compat.h

@@ -16,5 +16,6 @@ FORCE_SYMBOL_VERSION(expf, GLIBC_2.2.5);
 FORCE_SYMBOL_VERSION(log, GLIBC_2.2.5);
 FORCE_SYMBOL_VERSION(log2, GLIBC_2.2.5);
 FORCE_SYMBOL_VERSION(pow, GLIBC_2.2.5);
+FORCE_SYMBOL_VERSION(exp, GLIBC_2.2.5);
 
 #undef FORCE_SYMBOL_VERSION

.github/workflows/winget.yml

@@ -0,0 +1,54 @@
+name: Publish on Windows Package Manager
+
+on:
+  release:
+    types: [released]
+  workflow_dispatch:
+    inputs:
+      tag_name:
+        description: Release tag (version)
+        required: true
+
+jobs:
+  publish-winget:
+    name: Publish
+    runs-on: windows-latest
+    steps:
+      - name: Configure parameters
+        id: params
+        run: |
+          if ("${{ github.event_name }}" -eq "release") {
+            # Sometimes assets aren't immediately available, so we wait a bit for the first run
+            ${{ github.run_attempt == 1 && 'Start-Sleep -Seconds 300' || '' }}
+            
+            echo "assets_url=${{ github.event.release.assets_url }}" >> $env:GITHUB_OUTPUT
+            echo "version=${{ github.event.release.tag_name }}" >> $env:GITHUB_OUTPUT
+          } else {
+            $releaseUrl = "$env:GITHUB_API_URL/repos/clangd/clangd/releases/tags/${{ github.event.inputs.tag_name }}"
+            $assetsUrl = curl -sL $releaseUrl | ConvertFrom-Json | Select-Object -ExpandProperty assets_url
+            
+            echo "assets_url=$assetsUrl" >> $env:GITHUB_OUTPUT
+            echo "version=${{ github.event.inputs.tag_name }}" >> $env:GITHUB_OUTPUT
+          }
+
+      - name: Set up Komac
+        run: |
+          $releaseUrl = "$env:GITHUB_API_URL/repos/russellbanks/Komac/releases/latest"
+          $downloadUrl = curl -sL $releaseUrl | ConvertFrom-Json
+            | Select-Object -ExpandProperty assets
+            | Where-Object -Property name -like "komac-*-x86_64-pc-windows-msvc.exe"
+            | Select-Object -ExpandProperty browser_download_url
+            | Select-Object -First 1
+          curl -sL $downloadUrl -o komac.exe
+          ./komac --version
+
+      - name: Submit package
+        env:
+          GITHUB_TOKEN: ${{ secrets.WINGET_TOKEN }}
+        run: |
+          $releaseUrl = curl -sL ${{ steps.params.outputs.assets_url }} | ConvertFrom-Json
+            | Where-Object -Property name -like "clangd-windows-*.zip"
+            | Select-Object -ExpandProperty browser_download_url
+          
+          ./komac sync-fork
+          ./komac update LLVM.clangd -v ${{ steps.params.outputs.version }} -u $releaseUrl -s