From 6b50d6c09a602fe1e662c64b3f510b0219eb0de3 Mon Sep 17 00:00:00 2001 From: GekkieHenkie <33967804+GekkieHenkie@users.noreply.github.com> Date: Tue, 9 Apr 2019 19:49:57 +0200 Subject: [PATCH] Update CMakeLists.txt Currently (well, at least on Windows), the created DLL files aren't installed in the correct output directory after a build. The dll files are installed in the 'lib' directory. Which actually is the place for the static library or the shared library's symbols file (.lib), not the actual shared library's runtime. The shared library runtimes should be installed to the 'bin' output directory, as proposed in this PR. See the ```CONFIGURATIONS``` option in [Install command introduction in the CMake manual](https://cmake.org/cmake/help/v3.14/command/install.html#introduction). This also follows convention as used in other notable libraries as libpng, libogg/vorbis, freetype, zlib, tinyxml, etc. --- CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 36b0460..afbd75c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -76,7 +76,6 @@ IF ( glew-cmake_BUILD_SHARED ) TARGET_INCLUDE_DIRECTORIES( libglew_shared PUBLIC ${INCLUDE_DIR} ) TARGET_LINK_LIBRARIES( libglew_shared ${GL_LIBRARY} ${PLATFORM_SPECIFIC_LIBRARIES} ) - INSTALL( TARGETS libglew_shared DESTINATION lib ) INSTALL( TARGETS libglew_shared RUNTIME DESTINATION bin ) ENDIF ( ) @@ -91,7 +90,6 @@ IF ( glew-cmake_BUILD_SHARED ) TARGET_COMPILE_DEFINITIONS( libglewmx_shared INTERFACE GLEW_MX) TARGET_INCLUDE_DIRECTORIES( libglewmx_shared PUBLIC ${INCLUDE_DIR} ) TARGET_LINK_LIBRARIES( libglewmx_shared ${GL_LIBRARY} ${PLATFORM_SPECIFIC_LIBRARIES} ) - INSTALL( TARGETS libglewmx_shared DESTINATION lib ) INSTALL( TARGETS libglewmx_shared RUNTIME DESTINATION bin ) ENDIF ( ) ENDIF ( )