mirror of
https://github.com/glfw/glfw.git
synced 2024-11-11 13:03:52 +00:00
parent
18d7c241f8
commit
84c881c1a8
@ -2133,20 +2133,19 @@ void _glfwPlatformSetWindowIcon(_GLFWwindow* window,
|
|||||||
|
|
||||||
for (j = 0; j < images[i].width * images[i].height; j++)
|
for (j = 0; j < images[i].width * images[i].height; j++)
|
||||||
{
|
{
|
||||||
*target++ = (((unsigned long)images[i].pixels[j * 4 + 0]) << 16) |
|
*target++ = (((unsigned long) images[i].pixels[j * 4 + 0]) << 16) |
|
||||||
(((unsigned long)images[i].pixels[j * 4 + 1]) << 8) |
|
(((unsigned long) images[i].pixels[j * 4 + 1]) << 8) |
|
||||||
(((unsigned long)images[i].pixels[j * 4 + 2]) << 0) |
|
(((unsigned long) images[i].pixels[j * 4 + 2]) << 0) |
|
||||||
(((unsigned long)images[i].pixels[j * 4 + 3]) << 24);
|
(((unsigned long) images[i].pixels[j * 4 + 3]) << 24);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Important: Despite XChangeProperty docs indicating that `icon` (unsigned char*) would be
|
// NOTE: XChangeProperty expects 32-bit values like the image data above to be
|
||||||
// in the format of the icon image, e.g. 32-bit below, the function actually casts the ptr
|
// placed in the 32 least significant bits of individual longs. This is
|
||||||
// (unsigned char*) internally to (long*) and then if long is defined as 64-bits, as on IL64
|
// true even if long is 64-bit and a WM protocol calls for "packed" data.
|
||||||
// platforms, extracts only 32 bits from the long leaving the other 32 unused. That is, on a
|
// This is because of a historical mistake that then became part of the Xlib
|
||||||
// 64-bit platform XChangeProperty expects 64-bit integers representing 32-bit pixels.
|
// ABI. Xlib will pack these values into a regular array of 32-bit values
|
||||||
//
|
// before sending it over the wire.
|
||||||
// See https://github.com/glfw/glfw/pull/1986#issuecomment-962445299
|
|
||||||
XChangeProperty(_glfw.x11.display, window->x11.handle,
|
XChangeProperty(_glfw.x11.display, window->x11.handle,
|
||||||
_glfw.x11.NET_WM_ICON,
|
_glfw.x11.NET_WM_ICON,
|
||||||
XA_CARDINAL, 32,
|
XA_CARDINAL, 32,
|
||||||
|
Loading…
Reference in New Issue
Block a user