From cf4c510eacb5cc9a38e89df4e80b89fdb72b9d70 Mon Sep 17 00:00:00 2001 From: Grzesiek11 Date: Sat, 18 Nov 2023 02:17:40 +0100 Subject: [PATCH] Specify that synthetic key releases are only generated for named keys The current wording states that all keys have synthetic key release events generated after focus is lost, but keys that aren't named don't have any state held, so no such events are generated for them. The new wording clarifies that only named keys have the events generated for them. The same change was also applied to mouse buttons, though currently mouse buttons that aren't named aren't ever reported. --- CONTRIBUTORS.md | 1 + include/GLFW/glfw3.h | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 3ad802f2..c61d1ddf 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -267,6 +267,7 @@ video tutorials. - Jonas Ådahl - Lasse Öörni - Leonard König + - Grzesiek11 - All the unmentioned and anonymous contributors in the GLFW community, for bug reports, patches, feedback, testing and encouragement diff --git a/include/GLFW/glfw3.h b/include/GLFW/glfw3.h index 58b395cd..a99fc25e 100644 --- a/include/GLFW/glfw3.h +++ b/include/GLFW/glfw3.h @@ -5058,9 +5058,9 @@ GLFWAPI void glfwSetCursor(GLFWwindow* window, GLFWcursor* cursor); * [character callback](@ref glfwSetCharCallback) instead. * * When a window loses input focus, it will generate synthetic key release - * events for all pressed keys. You can tell these events from user-generated - * events by the fact that the synthetic ones are generated after the focus - * loss event has been processed, i.e. after the + * events for all pressed named keys. You can tell these events from + * user-generated events by the fact that the synthetic ones are generated + * after the focus loss event has been processed, i.e. after the * [window focus callback](@ref glfwSetWindowFocusCallback) has been called. * * The scancode of a key is specific to that platform or sometimes even to that @@ -5188,9 +5188,9 @@ GLFWAPI GLFWcharmodsfun glfwSetCharModsCallback(GLFWwindow* window, GLFWcharmods * is called when a mouse button is pressed or released. * * When a window loses input focus, it will generate synthetic mouse button - * release events for all pressed mouse buttons. You can tell these events - * from user-generated events by the fact that the synthetic ones are generated - * after the focus loss event has been processed, i.e. after the + * release events for all pressed named mouse buttons. You can tell these + * events from user-generated events by the fact that the synthetic ones are + * generated after the focus loss event has been processed, i.e. after the * [window focus callback](@ref glfwSetWindowFocusCallback) has been called. * * @param[in] window The window whose callback to set.