Zengtudor/glfw
1
0
Fork 0
mirror of https://github.com/glfw/glfw.git synced 2025-06-16 12:37:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some keys not repeating in Wayland

Browse Source 
According to https://xkbcommon.org/doc/current/group__components.html#ga9d7f998efeca98b3afc7c257bbac90a8, xkb_keymap_key_repeats requires keymap and keycode as input.

```
int xkb_keymap_key_repeats( struct xkb_keymap * keymap,
			    xkb_keycode_t key
)
```

However, in wl_init.c:inputChar, we are passing in xkb_keysym_t which was a type mismatch.

This results in some keys not repeating when they should and vice versa.
This commit is contained in:
Koray Kilinc 2021-06-01 13:40:44 -07:00
parent 114776a246
commit f3e7afa3ff
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -231,6 +231,7 @@ information on what to include when reporting a bug.
- [Wayland] Bugfix: Client-Side Decorations were destroyed in the wrong worder - [Wayland] Bugfix: Client-Side Decorations were destroyed in the wrong worder
(#1798) (#1798)
- [Wayland] Bugfix: Monitors physical size could report zero (#1784,#1792) - [Wayland] Bugfix: Monitors physical size could report zero (#1784,#1792)
- [Wayland] Bugfix: Some keys were not repeating in Wayland
- [POSIX] Bugfix: `CLOCK_MONOTONIC` was not correctly tested for or enabled - [POSIX] Bugfix: `CLOCK_MONOTONIC` was not correctly tested for or enabled
- [NSGL] Removed enforcement of forward-compatible flag for core contexts - [NSGL] Removed enforcement of forward-compatible flag for core contexts
- [NSGL] Bugfix: `GLFW_COCOA_RETINA_FRAMEBUFFER` had no effect on newer - [NSGL] Bugfix: `GLFW_COCOA_RETINA_FRAMEBUFFER` had no effect on newer
@ -472,6 +473,7 @@ skills.
- Jonas Ådahl - Jonas Ådahl
- Lasse Öörni - Lasse Öörni
- Leonard König - Leonard König
- Koray Kilinc
- All the unmentioned and anonymous contributors in the GLFW community, for bug - All the unmentioned and anonymous contributors in the GLFW community, for bug
reports, patches, feedback, testing and encouragement reports, patches, feedback, testing and encouragement

2
src/wl_init.c
View File

@ -552,7 +552,7 @@ static GLFWbool inputChar(_GLFWwindow* window, uint32_t key)
} }
} }
return xkb_keymap_key_repeats(_glfw.wl.xkb.keymap, syms[0]); return xkb_keymap_key_repeats(_glfw.wl.xkb.keymap, code);
} }
static void keyboardHandleKey(void* data, static void keyboardHandleKey(void* data,