From fc89a317fcb538f800dfbd9a01b05a81c9e918d7 Mon Sep 17 00:00:00 2001 From: t1c Date: Wed, 30 Apr 2025 13:06:11 +0800 Subject: [PATCH] Update CMakeLists.txt MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit check_c_compiler_flag is used to check ​​compiler flags​​ (such as -Wall), not linker flags. Passing an empty string directly will result in checking nothing substantial, and the outcome may always be TRUE. --- src/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index aacdb296..d058c156 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -314,7 +314,7 @@ if (GLFW_BUILD_SHARED_LIBRARY) # Compatibility with data execution prevention (DEP) cmake_push_check_state() set(CMAKE_REQUIRED_FLAGS "-Wl,--nxcompat") - check_c_compiler_flag("" _GLFW_HAS_DEP) + check_linker_flag(C "-Wl,--nxcompat" _GLFW_HAS_DEP) if (_GLFW_HAS_DEP) target_link_libraries(glfw PRIVATE "-Wl,--nxcompat") endif() @@ -323,7 +323,7 @@ if (GLFW_BUILD_SHARED_LIBRARY) # Compatibility with address space layout randomization (ASLR) cmake_push_check_state() set(CMAKE_REQUIRED_FLAGS "-Wl,--dynamicbase") - check_c_compiler_flag("" _GLFW_HAS_ASLR) + check_linker_flag(C "-Wl,--dynamicbase" _GLFW_HAS_ASLR) if (_GLFW_HAS_ASLR) target_link_libraries(glfw PRIVATE "-Wl,--dynamicbase") endif() @@ -332,7 +332,7 @@ if (GLFW_BUILD_SHARED_LIBRARY) # Compatibility with 64-bit address space layout randomization (ASLR) cmake_push_check_state() set(CMAKE_REQUIRED_FLAGS "-Wl,--high-entropy-va") - check_c_compiler_flag("" _GLFW_HAS_64ASLR) + check_linker_flag(C "-Wl,--high-entropy-va" _GLFW_HAS_64ASLR) if (_GLFW_HAS_64ASLR) target_link_libraries(glfw PRIVATE "-Wl,--high-entropy-va") endif()