Merge 662454b552 into 768e81a0eb

Key repeat shoud only be halted when the repeating key
is released, not when another key is released.

CONTRIBUTORS.md

@@ -68,6 +68,7 @@ video tutorials.
  - Jan Ekström
  - Siavash Eliasi
  - er-azh
+ - Jan Hendrik Farr
  - Ahmad Fatoum
  - Nikita Fediuchin
  - Felipe Ferreira

README.md

@@ -138,6 +138,7 @@ information on what to include when reporting a bug.
  - [Wayland] Bugfix: Retrieved cursor position would be incorrect when hovering over
                      fallback decorations
  - [Wayland] Bugfix: Fallback decorations would report scroll events
+ - [Wayland] Bugfix: Keyboard repeat events halted when any key is released (#2568)
  - [X11] Bugfix: Running without a WM could trigger an assert (#2593,#2601,#2631)
  - [Null] Added Vulkan 'window' surface creation via `VK_EXT_headless_surface`
  - [Null] Added EGL context creation on Mesa via `EGL_MESA_platform_surfaceless`

docs/input.md

@@ -940,9 +940,10 @@ with @ref glfwGetTimerValue.
 uint64_t value = glfwGetTimerValue();
 ```
 
-This value is in 1 / frequency seconds.  The frequency of the raw
+This function returns the current value of the raw timer. To get the current time in 
-timer varies depending on the operating system and hardware.  You can query the
+1 / frequency seconds, use `glfwGetTimerValue() / glfwGetTimerFrequency()`.
-frequency, in Hz, with @ref glfwGetTimerFrequency.
+The frequency of the rawtimer varies depending on the operating system and hardware.
+You can query the frequency, in Hz, with @ref glfwGetTimerFrequency.
 
 ```c
 uint64_t frequency = glfwGetTimerFrequency();

include/GLFW/glfw3.h

@@ -6037,9 +6037,12 @@ GLFWAPI void glfwSetTime(double time);
 
 /*! @brief Returns the current value of the raw timer.
  *
- *  This function returns the current value of the raw timer, measured in
+ *  This function returns the current value of the raw timer. To get the 
- *  1 / frequency seconds.  To get the frequency, call @ref
+ *  current time measured in 1 / frequency seconds, use 
- *  glfwGetTimerFrequency.
+ *  @ref glfwGetTimerValue / @ref glfwGetTimerFrequency.
+ *  To get the frequency, call @ref glfwGetTimerFrequency.
+ *  
+ *  
  *
  *  @return The value of the timer, or zero if an
  *  [error](@ref error_handling) occurred.

src/wl_window.c

@@ -1838,10 +1838,11 @@ static void keyboardHandleKey(void* userData,
 
             timer.it_value.tv_sec = _glfw.wl.keyRepeatDelay / 1000;
             timer.it_value.tv_nsec = (_glfw.wl.keyRepeatDelay % 1000) * 1000000;
-        }
-    }
-
             timerfd_settime(_glfw.wl.keyRepeatTimerfd, 0, &timer, NULL);
+        }
+    } else if (scancode == _glfw.wl.keyRepeatScancode) {
+        timerfd_settime(_glfw.wl.keyRepeatTimerfd, 0, &timer, NULL);
+    }
 
     _glfwInputKey(window, key, scancode, action, _glfw.wl.xkb.modifiers);